2008-06-12 22:13:37

by Adrian Bunk

Subject: [2.6 patch] mn10300: export kernel_thread

This patch fixes thefollowing build error:

<-- snip -->

...
MODPOST 1310 modules
ERROR: "kernel_thread" [net/sunrpc/sunrpc.ko] undefined!
ERROR: "kernel_thread" [net/ipv4/ipvs/ip_vs.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/hidp/hidp.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/cmtp/cmtp.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/bnep/bnep.ko] undefined!
ERROR: "kernel_thread" [fs/nfs/nfs.ko] undefined!
ERROR: "kernel_thread" [fs/lockd/lockd.ko] undefined!
ERROR: "kernel_thread" [fs/jffs2/jffs2.ko] undefined!
...
WARNING: modpost: Found 2 section mismatch(es).

<-- snip -->

Reported-by: Adrian Bunk <[email protected]>
Signed-off-by: Adrian Bunk <[email protected]>

---

arch/mn10300/kernel/mn10300_ksyms.c | 3 +++
1 file changed, 3 insertions(+)

f6120ef1dbb0831e753b6f241bbca4600aa94c10 diff --git a/arch/mn10300/kernel/mn10300_ksyms.c b/arch/mn10300/kernel/mn10300_ksyms.c
index 6d19628..aba584a 100644
--- a/arch/mn10300/kernel/mn10300_ksyms.c
+++ b/arch/mn10300/kernel/mn10300_ksyms.c
@@ -10,6 +10,7 @@
*/
#include <linux/module.h>
#include <asm/uaccess.h>
+#include <asm/processor.h>


EXPORT_SYMBOL(change_bit);
@@ -35,3 +36,5 @@ EXPORT_SYMBOL(__ashrdi3);
EXPORT_SYMBOL(__ashldi3);
EXPORT_SYMBOL(__lshrdi3);
EXPORT_SYMBOL(__negdi2);
+
+EXPORT_SYMBOL(kernel_thread);

2008-06-13 13:11:55

by David Howells

Subject: Re: [2.6 patch] mn10300: export kernel_thread

Adrian Bunk <[email protected]> wrote:

> --- a/arch/mn10300/kernel/mn10300_ksyms.c
> +++ b/arch/mn10300/kernel/mn10300_ksyms.c

Why put it here? It should really go with the definition of kernel_thread()
in arch/mn10300/kernel/process.c.

I've just posted my own patch to deal with this and empty_zero_page. I also
submitted an additional patch to provide __ucmpdi2() so that allmodconfig
builds for me.

David

2008-06-13 13:23:34

by Adrian Bunk

Subject: Re: [2.6 patch] mn10300: export kernel_thread

On Fri, Jun 13, 2008 at 02:11:16PM +0100, David Howells wrote:
> Adrian Bunk <[email protected]> wrote:
>
> > --- a/arch/mn10300/kernel/mn10300_ksyms.c
> > +++ b/arch/mn10300/kernel/mn10300_ksyms.c
>
> Why put it here?

Because I was blind....

> It should really go with the definition of kernel_thread()
> in arch/mn10300/kernel/process.c.
>
> I've just posted my own patch to deal with this and empty_zero_page. I also
> submitted an additional patch to provide __ucmpdi2() so that allmodconfig
> builds for me.

Thanks!

> David

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed