2008-06-06 15:57:33

by Ben Dooks

[permalink] [raw]
Subject: [patch 11/15] MMC: Fix the retcode in the S3C24XX MMC/SD driver

Fix the error codes

Signed-off-by: Ben Dooks <[email protected]>

Index: linux-2.6.26-rc5-q/drivers/mmc/host/s3cmci.c
===================================================================
--- linux-2.6.26-rc5-q.orig/drivers/mmc/host/s3cmci.c 2008-06-06 15:46:35.000000000 +0100
+++ linux-2.6.26-rc5-q/drivers/mmc/host/s3cmci.c 2008-06-06 15:47:28.000000000 +0100
@@ -11,6 +11,7 @@
#include <linux/module.h>
#include <linux/dma-mapping.h>
#include <linux/clk.h>
+#include <linux/mmc/core.h>
#include <linux/mmc/mmc.h>
#include <linux/mmc/host.h>
#include <linux/platform_device.h>
@@ -28,6 +29,12 @@

#define DRIVER_NAME "s3c-mci"

+#define MMC_ERR_NONE (0)
+#define MMC_ERR_DMA EINVAL
+#define MMC_ERR_TIMEOUT ETIMEDOUT
+#define MMC_ERR_BADCRC EILSEQ
+#define MMC_ERR_FIFO EILSEQ
+
enum dbg_channels {
dbg_err = (1 << 0),
dbg_debug = (1 << 1),

--
Ben ([email protected], http://www.fluff.org/)

'a smiley only costs 4 bytes'


2008-06-14 16:25:54

by Pierre Ossman

[permalink] [raw]
Subject: Re: [patch 11/15] MMC: Fix the retcode in the S3C24XX MMC/SD driver

On Fri, 06 Jun 2008 16:51:28 +0100
Ben Dooks <[email protected]> wrote:

> Fix the error codes
>
> Signed-off-by: Ben Dooks <[email protected]>
>

NAK, for rather obvious reasons.


Attachments:
signature.asc (197.00 B)

2008-06-17 23:33:53

by Ben Dooks

[permalink] [raw]
Subject: Re: [patch 11/15] MMC: Fix the retcode in the S3C24XX MMC/SD driver

On Sat, Jun 14, 2008 at 06:25:05PM +0200, Pierre Ossman wrote:
> On Fri, 06 Jun 2008 16:51:28 +0100
> Ben Dooks <[email protected]> wrote:
>
> > Fix the error codes
> >
> > Signed-off-by: Ben Dooks <[email protected]>
> >
>
> NAK, for rather obvious reasons.

Fixed and folded back into patch #2.

thanks,
--
Ben

Q: What's a light-year?
A: One-third less calories than a regular year.