2008-06-15 16:15:19

by Adrian Bunk

[permalink] [raw]
Subject: parisc: pcibios_init_bus() isn't called

arch/parisc/kernel/pci.c:pcibios_init_bus() never gets called - this
doesn't seem to be intentionally?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2008-06-16 22:41:30

by Grant Grundler

[permalink] [raw]
Subject: Re: parisc: pcibios_init_bus() isn't called

On Sun, Jun 15, 2008 at 07:13:27PM +0300, Adrian Bunk wrote:
> arch/parisc/kernel/pci.c:pcibios_init_bus() never gets called - this
> doesn't seem to be intentionally?

I think this is accidentally abandoned code and introduced here:
http://lkml.org/lkml/2001/12/22/43

So it was called from pci_do_scan_bus(). Can you track down when this
was removed from pci_do_scan_bus() ?

But it was once used by parisc port:
http://lists.parisc-linux.org/pipermail/parisc-linux/2001-June/037259.html

and then perhaps got removed soon after in the generic code:
http://www.cs.helsinki.fi/linux/linux-kernel/2003-01/0388.html

But I'm not finding the exact patch that removed it.

thanks,
grant

2008-06-17 09:03:19

by Adrian Bunk

[permalink] [raw]
Subject: Re: parisc: pcibios_init_bus() isn't called

On Mon, Jun 16, 2008 at 04:41:07PM -0600, Grant Grundler wrote:
> On Sun, Jun 15, 2008 at 07:13:27PM +0300, Adrian Bunk wrote:
> > arch/parisc/kernel/pci.c:pcibios_init_bus() never gets called - this
> > doesn't seem to be intentionally?
>
> I think this is accidentally abandoned code and introduced here:
> http://lkml.org/lkml/2001/12/22/43

As far as I can see this patch never made it into the tree?

Ivan, do you remember details about this?

> So it was called from pci_do_scan_bus(). Can you track down when this
> was removed from pci_do_scan_bus() ?
>
> But it was once used by parisc port:
> http://lists.parisc-linux.org/pipermail/parisc-linux/2001-June/037259.html
>
> and then perhaps got removed soon after in the generic code:
> http://www.cs.helsinki.fi/linux/linux-kernel/2003-01/0388.html
>
> But I'm not finding the exact patch that removed it.
>
> thanks,
> grant

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed