Signed-off-by: Robert Richter <[email protected]>
---
arch/x86/kernel/apic_64.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
index d8d03e0..2a9f4bc 100644
--- a/arch/x86/kernel/apic_64.c
+++ b/arch/x86/kernel/apic_64.c
@@ -215,12 +215,14 @@ u8 setup_APIC_eilvt_mce(u8 vector, u8 msg_type, u8 mask)
setup_APIC_eilvt(APIC_EILVT_LVTOFF_MCE, vector, msg_type, mask);
return APIC_EILVT_LVTOFF_MCE;
}
+EXPORT_SYMBOL(setup_APIC_eilvt_mce);
u8 setup_APIC_eilvt_ibs(u8 vector, u8 msg_type, u8 mask)
{
setup_APIC_eilvt(APIC_EILVT_LVTOFF_IBS, vector, msg_type, mask);
return APIC_EILVT_LVTOFF_IBS;
}
+EXPORT_SYMBOL(setup_APIC_eilvt_ibs);
/*
* Program the next event, relative to now
--
1.5.1.6
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]
On Wed, 13 Feb 2008 16:19:36 +0100 (CET)
"Robert Richter" <[email protected]> wrote:
> Signed-off-by: Robert Richter <[email protected]>
> ---
> arch/x86/kernel/apic_64.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
> index d8d03e0..2a9f4bc 100644
> --- a/arch/x86/kernel/apic_64.c
> +++ b/arch/x86/kernel/apic_64.c
> @@ -215,12 +215,14 @@ u8 setup_APIC_eilvt_mce(u8 vector, u8 msg_type,
> u8 mask) setup_APIC_eilvt(APIC_EILVT_LVTOFF_MCE, vector, msg_type,
> mask); return APIC_EILVT_LVTOFF_MCE;
> }
> +EXPORT_SYMBOL(setup_APIC_eilvt_mce);
>
> u8 setup_APIC_eilvt_ibs(u8 vector, u8 msg_type, u8 mask)
> {
> setup_APIC_eilvt(APIC_EILVT_LVTOFF_IBS, vector, msg_type,
> mask); return APIC_EILVT_LVTOFF_IBS;
> }
> +EXPORT_SYMBOL(setup_APIC_eilvt_ibs);
which modules would even consider using any of these?
Doesn't sound like something we should export..
--
If you want to reach me at my work email, use [email protected]
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
On 13.02.08 14:32:56, Arjan van de Ven wrote:
> On Wed, 13 Feb 2008 16:19:36 +0100 (CET)
> "Robert Richter" <[email protected]> wrote:
>
> > Signed-off-by: Robert Richter <[email protected]>
> > ---
> > arch/x86/kernel/apic_64.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
> > index d8d03e0..2a9f4bc 100644
> > --- a/arch/x86/kernel/apic_64.c
> > +++ b/arch/x86/kernel/apic_64.c
> > @@ -215,12 +215,14 @@ u8 setup_APIC_eilvt_mce(u8 vector, u8 msg_type,
> > u8 mask) setup_APIC_eilvt(APIC_EILVT_LVTOFF_MCE, vector, msg_type,
> > mask); return APIC_EILVT_LVTOFF_MCE;
> > }
> > +EXPORT_SYMBOL(setup_APIC_eilvt_mce);
> >
> > u8 setup_APIC_eilvt_ibs(u8 vector, u8 msg_type, u8 mask)
> > {
> > setup_APIC_eilvt(APIC_EILVT_LVTOFF_IBS, vector, msg_type,
> > mask); return APIC_EILVT_LVTOFF_IBS;
> > }
> > +EXPORT_SYMBOL(setup_APIC_eilvt_ibs);
>
> which modules would even consider using any of these?
> Doesn't sound like something we should export..
For IBS it is Perfmon. See here:
http://git.kernel.org/?p=linux/kernel/git/eranian/linux-2.6.git;a=commit;h=7caef3e19d17349f869884f5adf7c9823e32ade7
MCE export has been added for consistency reasons to allow modules to
enable MCE.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]
On Thu, 14 Feb 2008 10:40:36 +0100
"Robert Richter" <[email protected]> wrote:
> On 13.02.08 14:32:56, Arjan van de Ven wrote:
> > On Wed, 13 Feb 2008 16:19:36 +0100 (CET)
> > "Robert Richter" <[email protected]> wrote:
> >
> > > Signed-off-by: Robert Richter <[email protected]>
> > > ---
> > > arch/x86/kernel/apic_64.c | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
> > > index d8d03e0..2a9f4bc 100644
> > > --- a/arch/x86/kernel/apic_64.c
> > > +++ b/arch/x86/kernel/apic_64.c
> > > @@ -215,12 +215,14 @@ u8 setup_APIC_eilvt_mce(u8 vector, u8
> > > msg_type, u8 mask) setup_APIC_eilvt(APIC_EILVT_LVTOFF_MCE,
> > > vector, msg_type, mask); return APIC_EILVT_LVTOFF_MCE;
> > > }
> > > +EXPORT_SYMBOL(setup_APIC_eilvt_mce);
> > >
> > > u8 setup_APIC_eilvt_ibs(u8 vector, u8 msg_type, u8 mask)
> > > {
> > > setup_APIC_eilvt(APIC_EILVT_LVTOFF_IBS, vector, msg_type,
> > > mask); return APIC_EILVT_LVTOFF_IBS;
> > > }
> > > +EXPORT_SYMBOL(setup_APIC_eilvt_ibs);
> >
> > which modules would even consider using any of these?
> > Doesn't sound like something we should export..
>
> For IBS it is Perfmon. See here:
> http://git.kernel.org/?p=linux/kernel/git/eranian/linux-2.6.git;a=commit;h=7caef3e19d17349f869884f5adf7c9823e32ade7
>
perfmon doesn't seem to go anywhere lately, so realistically this chunk should be part of the perfmon tree.
> MCE export has been added for consistency reasons to allow modules to
> enable MCE.
no module does that right now, nor should it. MCE is really something the core kernel should do right?
"consistency reasons" isn't "just export everything used or not", it's "oh this makes sense as part of a well
thought out, generic consistent api". This one isn't./
--
If you want to reach me at my work email, use [email protected]
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
Arjan,
do you see a way of how to get these EXPORT_SYMBOLs mainline? Better
use EXPORT_SYMBOL_GPL? Or is it common sense to add EXPORT_SYMBOLs to
mainline not until there are already use cases in the mainline?
At least the IBS symbol is needed for Perfmon but potentially also for
OProfile. This will allow the use of loadable Perfmon kernel modules,
especially if some lightwight Perfmon features are already upstream.
Also, APIC setup is more general and not Perfmon related. So I
think the Perfmon tree is not the right place to keep the code.
I don't know, if there is a use case for loadable MCE modules. We
could skip this, but as I said, code consistency...
Thanks,
-Robert
On 14.02.08 08:47:49, Arjan van de Ven wrote:
> > > > +EXPORT_SYMBOL(setup_APIC_eilvt_ibs);
> > >
> > > which modules would even consider using any of these?
> > > Doesn't sound like something we should export..
> >
> > For IBS it is Perfmon. See here:
> > http://git.kernel.org/?p=linux/kernel/git/eranian/linux-2.6.git;a=commit;h=7caef3e19d17349f869884f5adf7c9823e32ade7
> >
>
> perfmon doesn't seem to go anywhere lately, so realistically this chunk should be part of the perfmon tree.
[...]
> > MCE export has been added for consistency reasons to allow modules to
> > enable MCE.
>
> no module does that right now, nor should it. MCE is really something the core kernel should do right?
> "consistency reasons" isn't "just export everything used or not", it's "oh this makes sense as part of a well
> thought out, generic consistent api". This one isn't./
[...]
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]
On Thu, 19 Jun 2008 19:00:56 +0200
Robert Richter <[email protected]> wrote:
> Arjan,
>
> do you see a way of how to get these EXPORT_SYMBOLs mainline?
it's easy... submit the code that uses them.....
--
If you want to reach me at my work email, use [email protected]
For development, discussion and tips for power savings,
visit http://www.lesswatts.org