2008-06-24 14:51:24

by Miklos Szeredi

[permalink] [raw]
Subject: [patch 1/5] vfs: truncate: dont check immutable twice

From: Miklos Szeredi <[email protected]>

vfs_permission(MAY_WRITE) already checked for the inode being
immutable, so no need to repeat it.

Signed-off-by: Miklos Szeredi <[email protected]>
Acked-by: Christoph Hellwig <[email protected]>
---
fs/open.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/fs/open.c
===================================================================
--- linux-2.6.orig/fs/open.c 2008-06-11 10:16:13.000000000 +0200
+++ linux-2.6/fs/open.c 2008-06-13 13:15:01.000000000 +0200
@@ -254,7 +254,7 @@ static long do_sys_truncate(const char _
goto mnt_drop_write_and_out;

error = -EPERM;
- if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
+ if (IS_APPEND(inode))
goto mnt_drop_write_and_out;

error = get_write_access(inode);

--