On Thu, May 01, 2008 at 03:27:26PM -0700, Linus Torvalds wrote:
>
>
> On Thu, 1 May 2008, Andrew Morton wrote:
> > >
> > > I see only the following choices:
> > > - remove __weak and replace all current usages
> > > - move all __weak functions into own files, and ensure that also happens
> > > for future usages
> > > - #error for gcc 4.1.{0,1}
> >
> > Can we detect the {0,1}? __GNUC_EVEN_MORE_MINOR__?
>
> It's __GNUC_PATCHLEVEL__, I believe.
>
> So yes, we can distinguish 4.1.2 (good, and very common) from 4.1.{0,1}
> (bad, and rather uncommon).
>
> And yes, considering that 4.1.1 (and even more so 4.1.0) should be rare to
> begin with, I think it's better to just not support it.
Some talk and one and a half months later we still don't abort the build
for these gcc version.
If anyone has a better patch please step forward - otherwise I'd propose
the patch below.
> Linus
cu
Adrian
<-- snip -->
gcc 4.1.0 and 4.1.1 are known to miscompile the kernel:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27781
Usage of weak functions has become a common pattern in the kernel, and
usages get added in each kernel version increasing the probability of
bugs with each kernel release.
This miscompilation of weak functions can result in subtle runtime
errors.
#error for gcc 4.1.0 and 4.1.1 to prevent users from running into
this bug.
Note:
We already printed a #warning for gcc 4.1.0 due to a different bug.
Signed-off-by: Adrian Bunk <[email protected]>
---
ee78871a1d85fe60958748c208389adb4031fefe diff --git a/init/main.c b/init/main.c
index f7fb200..bede344 100644
--- a/init/main.c
+++ b/init/main.c
@@ -76,8 +76,9 @@
* trouble.
*/
-#if __GNUC__ == 4 && __GNUC_MINOR__ == 1 && __GNUC_PATCHLEVEL__ == 0
-#warning gcc-4.1.0 is known to miscompile the kernel. A different compiler version is recommended.
+/* due to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27781 */
+#if __GNUC__ == 4 && __GNUC_MINOR__ == 1 && (__GNUC_PATCHLEVEL__ == 0 || __GNUC_PATCHLEVEL__ == 1)
+#error gcc 4.1.0 and 4.1.1 are known to miscompile the kernel.
#endif
static int kernel_init(void *);