2008-07-01 19:58:36

by Ingo Molnar

[permalink] [raw]
Subject: [git pull] scheduler fixes

Linus,

Please pull the latest scheduler fixes git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git sched-fixes-for-linus

I think that's the last one for v2.6.26. Thanks,

Ingo

------------------>
Raistlin (1):
sched: fix divide error when trying to configure rt_period to zero

kernel/sched.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index a66e856..94ead43 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -8502,6 +8502,9 @@ int sched_group_set_rt_period(struct task_group *tg, long rt_period_us)
rt_period = (u64)rt_period_us * NSEC_PER_USEC;
rt_runtime = tg->rt_bandwidth.rt_runtime;

+ if (rt_period == 0)
+ return -EINVAL;
+
return tg_set_bandwidth(tg, rt_period, rt_runtime);
}


2008-07-01 20:36:56

by Toralf Förster

[permalink] [raw]
Subject: Re: [git pull] scheduler fixes

Hello,

I've one question related to that patch:

At Tue Jul 1 22:35:30 CEST 2008 Ingo Molnar wrote :
>diff --git a/kernel/sched.c b/kernel/sched.c
>index a66e856..94ead43 100644
>--- a/kernel/sched.c
>+++ b/kernel/sched.c
>@@ -8502,6 +8502,9 @@ int sched_group_set_rt_period(struct task_group *tg, long rt_period_us)
> rt_period = (u64)rt_period_us * NSEC_PER_USEC;
> rt_runtime = tg->rt_bandwidth.rt_runtime;
>
>+ if (rt_period == 0)
>+ return -EINVAL;
>+
> return tg_set_bandwidth(tg, rt_period, rt_runtime);

Why isn't the check be make before rt_runtime is set ?

--
MfG/Sincerely

Toralf F?rster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3


Attachments:
(No filename) (677.00 B)
signature.asc (197.00 B)
This is a digitally signed message part.
Download all attachments