2008-07-10 17:05:04

by Glauber Costa

Subject: [PATCH] remove duplicate call to use_tsc_delay.

Integration generated a duplicate call to use_tsc_delay.
Particularly, the one that is done before we check for general
tsc usability seems wrong.

Signed-off-by: Glauber Costa <[email protected]>
---
arch/x86/kernel/tsc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 4a775d0..3c36f92 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -513,7 +513,6 @@ void __init tsc_init(void)
*/
for_each_possible_cpu(cpu)
set_cyc2ns_scale(cpu_khz, cpu);
- use_tsc_delay();

if (tsc_disabled > 0)
return;
--
1.5.5.1

2008-07-10 17:22:18

by Alok Kataria

Subject: Re: [PATCH] remove duplicate call to use_tsc_delay.

My bad,

Acked-by: Alok N Kataria <[email protected]>

Thanks !!.
--
Alok

On Thu, Jul 10, 2008 at 10:01 AM, Glauber Costa <[email protected]> wrote:
> Integration generated a duplicate call to use_tsc_delay.
> Particularly, the one that is done before we check for general
> tsc usability seems wrong.
>
> Signed-off-by: Glauber Costa <[email protected]>
> ---
> arch/x86/kernel/tsc.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index 4a775d0..3c36f92 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -513,7 +513,6 @@ void __init tsc_init(void)
> */
> for_each_possible_cpu(cpu)
> set_cyc2ns_scale(cpu_khz, cpu);
> - use_tsc_delay();
>
> if (tsc_disabled > 0)
> return;
> --
> 1.5.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2008-07-10 17:47:45

by Ingo Molnar

Subject: Re: [PATCH] remove duplicate call to use_tsc_delay.

* Glauber Costa <[email protected]> wrote:

> Integration generated a duplicate call to use_tsc_delay. Particularly,
> the one that is done before we check for general tsc usability seems
> wrong.

applied to tip/x86/core - thanks Glauber.

Ingo