2008-07-11 19:59:18

by Randy Dunlap

Subject: [PATCH -next] firmware: fix memmap printk format warnings

From: Randy Dunlap <[email protected]>
cc: Bernhard Walle <[email protected]>

Fix firmware/memmap printk format warnings:

linux-next-20080711/drivers/firmware/memmap.c:156: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
linux-next-20080711/drivers/firmware/memmap.c:161: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'

Signed-off-by: Randy Dunlap <[email protected]>
---
drivers/firmware/memmap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

--- linux-next-20080711.orig/drivers/firmware/memmap.c
+++ linux-next-20080711/drivers/firmware/memmap.c
@@ -153,12 +153,14 @@ int __init firmware_map_add_early(resour

static ssize_t start_show(struct firmware_map_entry *entry, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "0x%llx\n", entry->start);
+ return snprintf(buf, PAGE_SIZE, "0x%llx\n",
+ (unsigned long long)entry->start);
}

static ssize_t end_show(struct firmware_map_entry *entry, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "0x%llx\n", entry->end);
+ return snprintf(buf, PAGE_SIZE, "0x%llx\n",
+ (unsigned long long)entry->end);
}

static ssize_t type_show(struct firmware_map_entry *entry, char *buf)


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

2008-07-12 22:17:47

by Bernhard Walle

Subject: Re: [PATCH -next] firmware: fix memmap printk format warnings

* Randy Dunlap <[email protected]> [2008-07-11 12:58]:
>
> From: Randy Dunlap <[email protected]>
> cc: Bernhard Walle <[email protected]>
>
> Fix firmware/memmap printk format warnings:
>
> linux-next-20080711/drivers/firmware/memmap.c:156: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
> linux-next-20080711/drivers/firmware/memmap.c:161: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'

Thanks for the patch. I did not include that change in my cleanup sent
to Andrew to not conflict with that patch.


Bernhard
--
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development