Subject: [PATCH] Fix typos from signal_32/64.h merge

Fallout from commit 33185c504f8e521b398536b5a8d415779a24593c ("x86:
merge signal_32/64.h")

Thanks to Dick Streefland who provided an useful testcase on
http://lkml.org/lkml/2008/3/17/205 (only applicable to 2.6.24.x), that
helped a lot as a deterministic way to bisect an issue that leaded to
this fix.

Signed-off-by: Herton Ronaldo Krzesinski <[email protected]>
Signed-off-by: Luiz Fernando N. Capitulino <[email protected]>
---
include/asm-x86/signal.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-x86/signal.h b/include/asm-x86/signal.h
index f15186d..6dac493 100644
--- a/include/asm-x86/signal.h
+++ b/include/asm-x86/signal.h
@@ -181,12 +181,12 @@ typedef struct sigaltstack {
#ifdef __KERNEL__
#include <asm/sigcontext.h>

-#ifdef __386__
+#ifdef __i386__

#define __HAVE_ARCH_SIG_BITOPS

#define sigaddset(set,sig) \
- (__builtin_constantp(sig) \
+ (__builtin_constant_p(sig) \
? __const_sigaddset((set), (sig)) \
: __gen_sigaddset((set), (sig)))

--
1.5.6


Subject: Re: [PATCH] Fix typos from signal_32/64.h merge

Em Mon, 14 Jul 2008 17:40:23 -0300
Herton Ronaldo Krzesinski <[email protected]> escreveu:

| Fallout from commit 33185c504f8e521b398536b5a8d415779a24593c ("x86:
| merge signal_32/64.h")
|
| Thanks to Dick Streefland who provided an useful testcase on
| http://lkml.org/lkml/2008/3/17/205 (only applicable to 2.6.24.x), that
| helped a lot as a deterministic way to bisect an issue that leaded to
| this fix.

Just a small note. On 2.6.24.x this causes gdb to get unexpected
SIGTRAPs, which (for some reason) is easy to reproduce when debugging
C++/QT programs.

And I have no idea on what kind of bug this is causing in latest
2.6.26 kernel.

--
Luiz Fernando N. Capitulino

2008-07-18 15:59:24

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] Fix typos from signal_32/64.h merge


* Herton Ronaldo Krzesinski <[email protected]> wrote:

> Fallout from commit 33185c504f8e521b398536b5a8d415779a24593c ("x86:
> merge signal_32/64.h")
>
> Thanks to Dick Streefland who provided an useful testcase on
> http://lkml.org/lkml/2008/3/17/205 (only applicable to 2.6.24.x), that
> helped a lot as a deterministic way to bisect an issue that leaded to
> this fix.

applied to tip/x86/urgent, thanks Herton!

Ingo