2008-07-15 21:15:01

by Mike Travis

Subject: [PATCH 4/8] cpumask: Optimize cpumask_of_cpu in drivers/misc/sgi-xp/xpc_main.c

* Optimize various places where a pointer to the cpumask_of_cpu value
will result in reducing stack pressure.

Based on linux-2.6.tip/master at the following commit:

commit 0a91813e16ebd5c2d9b5c2acd5b7c91742112c4f
Merge: 9a635fa... 724dce0...
Author: Ingo Molnar <[email protected]>
Date: Tue Jul 15 14:55:17 2008 +0200

Signed-off-by: Mike Travis <[email protected]>
Cc: Dean Nelson <[email protected]>
---
drivers/misc/sgi-xp/xpc_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.tip.orig/drivers/misc/sgi-xp/xpc_main.c
+++ linux-2.6.tip/drivers/misc/sgi-xp/xpc_main.c
@@ -229,10 +229,11 @@ xpc_hb_checker(void *ignore)
int last_IRQ_count = 0;
int new_IRQ_count;
int force_IRQ = 0;
+ cpumask_of_cpu_ptr(cpumask, XPC_HB_CHECK_CPU);

/* this thread was marked active by xpc_hb_init() */

- set_cpus_allowed(current, cpumask_of_cpu(XPC_HB_CHECK_CPU));
+ set_cpus_allowed_ptr(current, cpumask);

/* set our heartbeating to other partitions into motion */
xpc_hb_check_timeout = jiffies + (xpc_hb_check_interval * HZ);

--

2008-07-16 11:17:25

by Dean Nelson

Subject: Re: [PATCH 4/8] cpumask: Optimize cpumask_of_cpu in drivers/misc/sgi-xp/xpc_main.c

On Tue, Jul 15, 2008 at 02:14:33PM -0700, Mike Travis wrote:
> * Optimize various places where a pointer to the cpumask_of_cpu value
> will result in reducing stack pressure.
>
> Based on linux-2.6.tip/master at the following commit:
>
> commit 0a91813e16ebd5c2d9b5c2acd5b7c91742112c4f
> Merge: 9a635fa... 724dce0...
> Author: Ingo Molnar <[email protected]>
> Date: Tue Jul 15 14:55:17 2008 +0200
>
> Signed-off-by: Mike Travis <[email protected]>
> Cc: Dean Nelson <[email protected]>
> ---
> drivers/misc/sgi-xp/xpc_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2.6.tip.orig/drivers/misc/sgi-xp/xpc_main.c
> +++ linux-2.6.tip/drivers/misc/sgi-xp/xpc_main.c
> @@ -229,10 +229,11 @@ xpc_hb_checker(void *ignore)
> int last_IRQ_count = 0;
> int new_IRQ_count;
> int force_IRQ = 0;
> + cpumask_of_cpu_ptr(cpumask, XPC_HB_CHECK_CPU);
>
> /* this thread was marked active by xpc_hb_init() */
>
> - set_cpus_allowed(current, cpumask_of_cpu(XPC_HB_CHECK_CPU));
> + set_cpus_allowed_ptr(current, cpumask);
>
> /* set our heartbeating to other partitions into motion */
> xpc_hb_check_timeout = jiffies + (xpc_hb_check_interval * HZ);
>

Acked-by: Dean Nelson <[email protected]>