Now memory_read_from_buffer() belongs in string.h
Signed-off-by: Akinobu Mita <[email protected]>
Cc: Andrew Vasquez <[email protected]>
Cc: "James E.J. Bottomley" <[email protected]>
Cc: Andrew Vasquez <[email protected]>
Cc: Seokmann Ju <[email protected]>
---
drivers/scsi/qla2xxx/qla_attr.c | 1 -
1 file changed, 1 deletion(-)
Index: 2.6-mmotm/drivers/scsi/qla2xxx/qla_attr.c
===================================================================
--- 2.6-mmotm.orig/drivers/scsi/qla2xxx/qla_attr.c
+++ 2.6-mmotm/drivers/scsi/qla2xxx/qla_attr.c
@@ -8,7 +8,6 @@
#include <linux/kthread.h>
#include <linux/vmalloc.h>
-#include <linux/fs.h>
static int qla24xx_vport_disable(struct fc_vport *, bool);
--
On Mon, 14 Jul 2008, Akinobu Mita wrote:
> Now memory_read_from_buffer() belongs in string.h
>
> Signed-off-by: Akinobu Mita <[email protected]>
> Cc: Andrew Vasquez <[email protected]>
> Cc: "James E.J. Bottomley" <[email protected]>
> Cc: Andrew Vasquez <[email protected]>
> Cc: Seokmann Ju <[email protected]>
If needed:
Acked-by: Andrew Vasquez <[email protected]>
BTW: is the memory_read_from_buffer() work for qla2xxx going in
through the mm tree submission path???
On Thu, 17 Jul 2008 16:12:35 -0700
Andrew Vasquez <[email protected]> wrote:
> On Mon, 14 Jul 2008, Akinobu Mita wrote:
>
> > Now memory_read_from_buffer() belongs in string.h
> >
> > Signed-off-by: Akinobu Mita <[email protected]>
> > Cc: Andrew Vasquez <[email protected]>
> > Cc: "James E.J. Bottomley" <[email protected]>
> > Cc: Andrew Vasquez <[email protected]>
> > Cc: Seokmann Ju <[email protected]>
>
> If needed:
>
> Acked-by: Andrew Vasquez <[email protected]>
Thanks. So we now have tested-by:you and acked-by:you. That'll do ;)
> BTW: is the memory_read_from_buffer() work for qla2xxx going in
> through the mm tree submission path???
FSVO "through", yeah. It's appeared on linux-scsi four times so far.
Last time James complained about the fs.h inclusion so Akinobu raised a
patch "move memory_read_from_buffer() from fs.h to string.h" which I
just merged.
I'll just keep pressing send - it'll get there sometime. Or you can
merge it if you like.
On Thu, 17 Jul 2008, Andrew Morton wrote:
> > On Mon, 14 Jul 2008, Akinobu Mita wrote:
> >
> > > Now memory_read_from_buffer() belongs in string.h
> > >
> > > Signed-off-by: Akinobu Mita <[email protected]>
> > > Cc: Andrew Vasquez <[email protected]>
> > > Cc: "James E.J. Bottomley" <[email protected]>
> > > Cc: Andrew Vasquez <[email protected]>
> > > Cc: Seokmann Ju <[email protected]>
> >
> > If needed:
> >
> > Acked-by: Andrew Vasquez <[email protected]>
>
> Thanks. So we now have tested-by:you and acked-by:you. That'll do ;)
>
> > BTW: is the memory_read_from_buffer() work for qla2xxx going in
> > through the mm tree submission path???
>
> FSVO "through", yeah. It's appeared on linux-scsi four times so far.
> Last time James complained about the fs.h inclusion so Akinobu raised a
> patch "move memory_read_from_buffer() from fs.h to string.h" which I
> just merged.
>
> I'll just keep pressing send - it'll get there sometime. Or you can
> merge it if you like.
Would it too bothersome if I were to just collapse the two patches and
submit the composite with the my next set of patches??? Seems silly
to add the oneliner to the history...
On Thu, 17 Jul 2008 16:44:16 -0700
Andrew Vasquez <[email protected]> wrote:
> On Thu, 17 Jul 2008, Andrew Morton wrote:
>
> > > On Mon, 14 Jul 2008, Akinobu Mita wrote:
> > >
> > > > Now memory_read_from_buffer() belongs in string.h
> > > >
> > > > Signed-off-by: Akinobu Mita <[email protected]>
> > > > Cc: Andrew Vasquez <[email protected]>
> > > > Cc: "James E.J. Bottomley" <[email protected]>
> > > > Cc: Andrew Vasquez <[email protected]>
> > > > Cc: Seokmann Ju <[email protected]>
> > >
> > > If needed:
> > >
> > > Acked-by: Andrew Vasquez <[email protected]>
> >
> > Thanks. So we now have tested-by:you and acked-by:you. That'll do ;)
> >
> > > BTW: is the memory_read_from_buffer() work for qla2xxx going in
> > > through the mm tree submission path???
> >
> > FSVO "through", yeah. It's appeared on linux-scsi four times so far.
> > Last time James complained about the fs.h inclusion so Akinobu raised a
> > patch "move memory_read_from_buffer() from fs.h to string.h" which I
> > just merged.
> >
> > I'll just keep pressing send - it'll get there sometime. Or you can
> > merge it if you like.
>
> Would it too bothersome if I were to just collapse the two patches and
> submit the composite with the my next set of patches??? Seems silly
> to add the oneliner to the history...
Sure, no probs.