2008-07-17 22:08:06

by Bernhard Walle

Subject: kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO

The current implementation reports the structure name as
VMCOREINFO_OSRELEASE in VMCOREINFO, e.g.

VMCOREINFO_OSRELEASE=init_uts_ns.name.release

That doesn't make sense because it's always the same. Instead, use the
value, e.g.

VMCOREINFO_OSRELEASE=2.6.26-rc3

That's also what the 'makedumpfile -g' does.

Signed-off-by: Bernhard Walle <[email protected]>

diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index 3265968..3c7784d 100644
--- a/include/linux/kexec.h
+++ b/include/linux/kexec.h
@@ -127,8 +127,8 @@ void vmcoreinfo_append_str(const char *fmt, ...)
__attribute__ ((format (printf, 1, 2)));
unsigned long paddr_vmcoreinfo_note(void);

-#define VMCOREINFO_OSRELEASE(name) \
- vmcoreinfo_append_str("OSRELEASE=%s\n", #name)
+#define VMCOREINFO_OSRELEASE(value) \
+ vmcoreinfo_append_str("OSRELEASE=%s\n", value)
#define VMCOREINFO_PAGESIZE(value) \
vmcoreinfo_append_str("PAGESIZE=%ld\n", value)
#define VMCOREINFO_SYMBOL(name) \

2008-07-18 14:04:48

by Vivek Goyal

Subject: Re: kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO

On Fri, Jul 18, 2008 at 12:07:45AM +0200, Bernhard Walle wrote:
> The current implementation reports the structure name as
> VMCOREINFO_OSRELEASE in VMCOREINFO, e.g.
>
> VMCOREINFO_OSRELEASE=init_uts_ns.name.release
>
> That doesn't make sense because it's always the same. Instead, use the
> value, e.g.
>
> VMCOREINFO_OSRELEASE=2.6.26-rc3
>
> That's also what the 'makedumpfile -g' does.
>
> Signed-off-by: Bernhard Walle <[email protected]>
>
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 3265968..3c7784d 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -127,8 +127,8 @@ void vmcoreinfo_append_str(const char *fmt, ...)
> __attribute__ ((format (printf, 1, 2)));
> unsigned long paddr_vmcoreinfo_note(void);
>
> -#define VMCOREINFO_OSRELEASE(name) \
> - vmcoreinfo_append_str("OSRELEASE=%s\n", #name)
> +#define VMCOREINFO_OSRELEASE(value) \
> + vmcoreinfo_append_str("OSRELEASE=%s\n", value)
> #define VMCOREINFO_PAGESIZE(value) \
> vmcoreinfo_append_str("PAGESIZE=%ld\n", value)
> #define VMCOREINFO_SYMBOL(name) \

Makes sense.

Acked-by: Vivek Goyal <[email protected]>

Thanks
Vivek