2008-07-22 17:21:19

by Adrian Bunk

Subject: [2.6 patch] make pnp_build_option() static

pnp_build_optionq() can now become static.

Signed-off-by: Adrian Bunk <[email protected]>

---
87ec46ea755fc5349371bf2208b30264da355699
diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
index 4cfe3a1..2e5b7eb 100644
--- a/drivers/pnp/resource.c
+++ b/drivers/pnp/resource.c
@@ -30,8 +30,9 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 }; /* reserve (don't use) some
* option registration
*/

-struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
- unsigned int option_flags)
+static struct pnp_option *pnp_build_option(struct pnp_dev *dev,
+ unsigned long type,
+ unsigned int option_flags)
{
struct pnp_option *option;

2008-07-23 19:01:27

by Bjorn Helgaas

Subject: Re: [2.6 patch] make pnp_build_option() static

On Tuesday 22 July 2008 11:20:21 am Adrian Bunk wrote:
> pnp_build_optionq() can now become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Bjorn Helgaas <[email protected]>

PNP patches have been going through the ACPI tree lately.
I copied Andi and Len.

> ---
> 87ec46ea755fc5349371bf2208b30264da355699
> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
> index 4cfe3a1..2e5b7eb 100644
> --- a/drivers/pnp/resource.c
> +++ b/drivers/pnp/resource.c
> @@ -30,8 +30,9 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 }; /* reserve (don't use) some
> * option registration
> */
>
> -struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
> - unsigned int option_flags)
> +static struct pnp_option *pnp_build_option(struct pnp_dev *dev,
> + unsigned long type,
> + unsigned int option_flags)
> {
> struct pnp_option *option;
>
>
>

2008-07-24 08:49:48

by Andi Kleen

Subject: Re: [2.6 patch] make pnp_build_option() static

Bjorn Helgaas wrote:
> On Tuesday 22 July 2008 11:20:21 am Adrian Bunk wrote:
>> pnp_build_optionq() can now become static.
>>
>> Signed-off-by: Adrian Bunk <[email protected]>
>
> Acked-by: Bjorn Helgaas <[email protected]>
>
> PNP patches have been going through the ACPI tree lately.
> I copied Andi and Len.

Looks good thanks. I'm currently a bit behind with patches because
I'm at OLS and still focussing on patches for .27 only, but I'll
process all the post .27 patches soon.

-Andi