2008-07-22 17:43:57

by Cong Wang

Subject: [Patch] uml: fix another build error

Fixed this error:

CC arch/um/drivers/vde_user.o
/home/wangcong/Projects/linux-2.6/arch/um/drivers/vde_user.c: In
function ‘vde_init_libstuff’:
/home/wangcong/Projects/linux-2.6/arch/um/drivers/vde_user.c:81:
error: implicit declaration of function ‘kmalloc’
/home/wangcong/Projects/linux-2.6/arch/um/drivers/vde_user.c:81:
warning: assignment makes pointer from integer without a cast
make[2]: *** [arch/um/drivers/vde_user.o] Error 1
make[1]: *** [arch/um/drivers/vde_user.ko] Error 2
make: *** [sub-make] Error 2

Signed-off-by: WANG Cong <[email protected]>
Cc: [email protected]

---
diff --git a/arch/um/drivers/vde_user.c b/arch/um/drivers/vde_user.c
index 56533db..744eacf 100644
--- a/arch/um/drivers/vde_user.c
+++ b/arch/um/drivers/vde_user.c
@@ -78,7 +78,7 @@ void vde_init_libstuff(struct vde_data *vpri, struct vde_init *init)
{
struct vde_open_args *args;

- vpri->args = kmalloc(sizeof(struct vde_open_args), UM_GFP_KERNEL);
+ vpri->args = uml_kmalloc(sizeof(struct vde_open_args), UM_GFP_KERNEL);
if (vpri->args == NULL) {
printk(UM_KERN_ERR "vde_init_libstuff - vde_open_args "
"allocation failed");

2008-07-23 15:48:26

by Jeff Dike

Subject: Re: [Patch] uml: fix another build error

On Tue, Jul 22, 2008 at 06:41:52PM +0100, WANG Cong wrote:
>
> Fixed this error:
>
> CC arch/um/drivers/vde_user.o
> /home/wangcong/Projects/linux-2.6/arch/um/drivers/vde_user.c: In
> function ‘vde_init_libstuff’:
> /home/wangcong/Projects/linux-2.6/arch/um/drivers/vde_user.c:81:
> error: implicit declaration of function ‘kmalloc’
> /home/wangcong/Projects/linux-2.6/arch/um/drivers/vde_user.c:81:
> warning: assignment makes pointer from integer without a cast
> make[2]: *** [arch/um/drivers/vde_user.o] Error 1
> make[1]: *** [arch/um/drivers/vde_user.ko] Error 2
> make: *** [sub-make] Error 2

Thanks - added to the queue.

Jeff

--
Work email - jdike at linux dot intel dot com