Subject: [PATCH] Let HP iLO driver depend on PCI
From: Heiko Carstens <[email protected]>
"HP iLO driver" causes this on s390:
drivers/misc/hpilo.c: In function 'doorbell_set':
drivers/misc/hpilo.c:147: error: implicit declaration of function 'iowrite8'
drivers/misc/hpilo.c: In function 'ilo_ccb_close':
drivers/misc/hpilo.c:204: error: implicit declaration of function 'iowrite32'
drivers/misc/hpilo.c:204: error: implicit declaration of function 'ioread32'
drivers/misc/hpilo.c:222: error: implicit declaration of function 'memset_io'
drivers/misc/hpilo.c:225: error: implicit declaration of function 'pci_free_consistent'
drivers/misc/hpilo.c: In function 'ilo_ccb_open':
drivers/misc/hpilo.c:244: error: implicit declaration of function 'pci_alloc_consistent'
drivers/misc/hpilo.c:245: warning: assignment makes pointer from integer without a cast
drivers/misc/hpilo.c:296: error: implicit declaration of function 'memcpy_toio'
drivers/misc/hpilo.c: In function 'ilo_unmap_device':
drivers/misc/hpilo.c:575: error: implicit declaration of function 'pci_iounmap'
drivers/misc/hpilo.c: In function 'ilo_map_device':
drivers/misc/hpilo.c:585: error: implicit declaration of function 'pci_iomap'
drivers/misc/hpilo.c:585: warning: assignment makes pointer from integer without a cast
drivers/misc/hpilo.c:592: warning: assignment makes pointer from integer without a cast
drivers/misc/hpilo.c:599: warning: assignment makes pointer from integer without a cast
make[2]: *** [drivers/misc/hpilo.o] Error 1
Just let it depend on PCI.
Cc: David Altobelli <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Heiko Carstens <[email protected]>
---
Sent already two weeks ago to Greg because it caused the same
build bug on linux-next.
drivers/misc/Kconfig | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/misc/Kconfig
===================================================================
--- linux-2.6.orig/drivers/misc/Kconfig
+++ linux-2.6/drivers/misc/Kconfig
@@ -425,6 +425,7 @@ config SGI_XP
config HP_ILO
tristate "Channel interface driver for HP iLO/iLO2 processor"
default n
+ depends on PCI
help
The channel interface driver allows applications to communicate
with iLO/iLO2 management processors present on HP ProLiant
On Fri, 25 Jul 2008 04:20:48 +0200 Heiko Carstens <[email protected]> wrote:
> Subject: [PATCH] Let HP iLO driver depend on PCI
>
> From: Heiko Carstens <[email protected]>
>
> "HP iLO driver" causes this on s390:
>
> drivers/misc/hpilo.c: In function 'doorbell_set':
> drivers/misc/hpilo.c:147: error: implicit declaration of function 'iowrite8'
> drivers/misc/hpilo.c: In function 'ilo_ccb_close':
> drivers/misc/hpilo.c:204: error: implicit declaration of function 'iowrite32'
> drivers/misc/hpilo.c:204: error: implicit declaration of function 'ioread32'
> drivers/misc/hpilo.c:222: error: implicit declaration of function 'memset_io'
> drivers/misc/hpilo.c:225: error: implicit declaration of function 'pci_free_consistent'
> drivers/misc/hpilo.c: In function 'ilo_ccb_open':
> drivers/misc/hpilo.c:244: error: implicit declaration of function 'pci_alloc_consistent'
> drivers/misc/hpilo.c:245: warning: assignment makes pointer from integer without a cast
> drivers/misc/hpilo.c:296: error: implicit declaration of function 'memcpy_toio'
> drivers/misc/hpilo.c: In function 'ilo_unmap_device':
> drivers/misc/hpilo.c:575: error: implicit declaration of function 'pci_iounmap'
> drivers/misc/hpilo.c: In function 'ilo_map_device':
> drivers/misc/hpilo.c:585: error: implicit declaration of function 'pci_iomap'
> drivers/misc/hpilo.c:585: warning: assignment makes pointer from integer without a cast
> drivers/misc/hpilo.c:592: warning: assignment makes pointer from integer without a cast
> drivers/misc/hpilo.c:599: warning: assignment makes pointer from integer without a cast
> make[2]: *** [drivers/misc/hpilo.o] Error 1
>
> Just let it depend on PCI.
Yeah, I already queued up the same patch as
drivers-misc-hpiloc-needs-config_pci.patch
Three weeks and nobody did an allmodconfig build on linux-next for s390
or m68k (at least).
Hi Andrew,
On Thu, 24 Jul 2008 21:56:52 -0700 Andrew Morton <[email protected]> wrote:
>
> Three weeks and nobody did an allmodconfig build on linux-next for s390
> or m68k (at least).
http://kisskb.ellerman.id.au/kisskb/branch/9/
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Fri, 25 Jul 2008 15:35:02 +1000 Stephen Rothwell <[email protected]> wrote:
> Hi Andrew,
>
> On Thu, 24 Jul 2008 21:56:52 -0700 Andrew Morton <[email protected]> wrote:
> >
> > Three weeks and nobody did an allmodconfig build on linux-next for s390
> > or m68k (at least).
>
> http://kisskb.ellerman.id.au/kisskb/branch/9/
>
Wow, lots of red.
May I revise my comment? Three weeks and nobody did anything about the
failing allmodconfig builds on linux-next and s390 (at least).
Is anyone actively monitoring that page and doing the requisite culprit-poking?
Hi Andrew,
On Thu, 24 Jul 2008 23:15:19 -0700 Andrew Morton <[email protected]> wrote:
>
> Wow, lots of red.
Yeah :-(
> May I revise my comment? Three weeks and nobody did anything about the
> failing allmodconfig builds on linux-next and s390 (at least).
>
> Is anyone actively monitoring that page and doing the requisite culprit-poking?
I should do more - I do most days look for new things.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Thu, Jul 24, 2008 at 11:15:19PM -0700, Andrew Morton wrote:
> On Fri, 25 Jul 2008 15:35:02 +1000 Stephen Rothwell <[email protected]> wrote:
>
> > Hi Andrew,
> >
> > On Thu, 24 Jul 2008 21:56:52 -0700 Andrew Morton <[email protected]> wrote:
> > >
> > > Three weeks and nobody did an allmodconfig build on linux-next for s390
> > > or m68k (at least).
> >
> > http://kisskb.ellerman.id.au/kisskb/branch/9/
> >
>
> Wow, lots of red.
>
> May I revise my comment? Three weeks and nobody did anything about the
> failing allmodconfig builds on linux-next and s390 (at least).
Not true. I sent patches for all (s390) build failures two weeks ago.
Nobody cared. Patch for this specific build failure is available
here http://marc.info/?l=linux-next&m=121577361309086&w=2 .
> Is anyone actively monitoring that page and doing the requisite culprit-poking?
Where to send patches to? And who takes care they get integrated before
the merge window opens?
On Fri, 25 Jul 2008 11:41:31 +0200 Heiko Carstens <[email protected]> wrote:
> On Thu, Jul 24, 2008 at 11:15:19PM -0700, Andrew Morton wrote:
> > On Fri, 25 Jul 2008 15:35:02 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > > Hi Andrew,
> > >
> > > On Thu, 24 Jul 2008 21:56:52 -0700 Andrew Morton <[email protected]> wrote:
> > > >
> > > > Three weeks and nobody did an allmodconfig build on linux-next for s390
> > > > or m68k (at least).
> > >
> > > http://kisskb.ellerman.id.au/kisskb/branch/9/
> > >
> >
> > Wow, lots of red.
> >
> > May I revise my comment? Three weeks and nobody did anything about the
> > failing allmodconfig builds on linux-next and s390 (at least).
>
> Not true. I sent patches for all (s390) build failures two weeks ago.
> Nobody cared. Patch for this specific build failure is available
> here http://marc.info/?l=linux-next&m=121577361309086&w=2 .
I doubt if the hpilo developers are watching linux-next for patches.
Stephen will have seen it and he might play the
feed-it-over-to-the-culprit game. But usually I do that.
It's always appreciated if the patch-creator can identify the
appropriate individuals for the Cc: as well.
> > Is anyone actively monitoring that page and doing the requisite culprit-poking?
>
> Where to send patches to?
Me, lkml, Stephen, maintainer(s).
> And who takes care they get integrated before
> the merge window opens?
Usually me. Maintainers will sometimes integrate the fix directly but
the success rate via that route is distressingly low.
> > > > > Three weeks and nobody did an allmodconfig build on linux-next for s390
> > > > > or m68k (at least).
> > > >
> > > > http://kisskb.ellerman.id.au/kisskb/branch/9/
> > > >
> > >
> > > Wow, lots of red.
> > >
> > > May I revise my comment? Three weeks and nobody did anything about the
> > > failing allmodconfig builds on linux-next and s390 (at least).
> >
> > Not true. I sent patches for all (s390) build failures two weeks ago.
> > Nobody cared. Patch for this specific build failure is available
> > here http://marc.info/?l=linux-next&m=121577361309086&w=2 .
>
> I doubt if the hpilo developers are watching linux-next for patches.
That's why I cc'ed them back then.
> > > Is anyone actively monitoring that page and doing the requisite culprit-poking?
> >
> > Where to send patches to?
>
> Me, lkml, Stephen, maintainer(s).
>
> > And who takes care they get integrated before
> > the merge window opens?
>
> Usually me. Maintainers will sometimes integrate the fix directly but
> the success rate via that route is distressingly low.
Ok, wasn't sure about where to send patches against linux-next to.
Will do next time.
Thanks,
Heiko
Heiko Carstens wrote:
>>
>> I doubt if the hpilo developers are watching linux-next for patches.
>
> That's why I cc'ed them back then.
>
Other than not make this mistake, is there anything I could have
done to help this process along?