2008-07-25 09:12:23

by Toralf Förster

[permalink] [raw]
Subject: commit a352def21a642 breaks UML

Hello,

that commit produces a make error at my system:

...
CC arch/um/drivers/line.o
arch/um/drivers/line.c: In function 'line_write_interrupt':
arch/um/drivers/line.c:366: error: 'struct tty_ldisc' has no member named 'write_wakeup'
arch/um/drivers/line.c:367: error: 'struct tty_ldisc' has no member named 'write_wakeup'
make[1]: *** [arch/um/drivers/line.o] Error 1
make: *** [arch/um/drivers] Error 2

--
MfG/Sincerely

Toralf F?rster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3


Attachments:
(No filename) (517.00 B)
signature.asc (197.00 B)
This is a digitally signed message part.
Download all attachments

2008-07-25 09:23:44

by Cong Wang

[permalink] [raw]
Subject: Re: commit a352def21a642 breaks UML


>Hello,
>
>that commit produces a make error at my system:
>
>...
> CC arch/um/drivers/line.o
>arch/um/drivers/line.c: In function 'line_write_interrupt':
>arch/um/drivers/line.c:366: error: 'struct tty_ldisc' has no member named 'write_wakeup'
>arch/um/drivers/line.c:367: error: 'struct tty_ldisc' has no member named 'write_wakeup'
>make[1]: *** [arch/um/drivers/line.o] Error 1
>make: *** [arch/um/drivers] Error 2

Fixed by: http://lkml.org/lkml/2008/7/24/279

Thanks.

--
The opposite of love is not hate, but indifference.
--Elie Wiesel

2008-07-25 10:11:49

by Alan Cox

[permalink] [raw]
Subject: Re: commit a352def21a642 breaks UML

On Fri, Jul 25, 2008 at 11:12:08AM +0200, Toralf F?rster wrote:
> Hello,
>
> that commit produces a make error at my system:

Patches have been posted. um was poking around in the innards of the tty
layer in a file hidden in an arch subdirectory so it got missed. Swap that
problem chunk for

tty_wakeup(tty)