On powerpc (allyesconfig build) we get this error:
drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'
Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/isdn/hardware/mISDN/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/isdn/hardware/mISDN/Kconfig b/drivers/isdn/hardware/mISDN/Kconfig
index 1479348..9cd5f5f 100644
--- a/drivers/isdn/hardware/mISDN/Kconfig
+++ b/drivers/isdn/hardware/mISDN/Kconfig
@@ -7,6 +7,7 @@ config MISDN_HFCPCI
tristate "Support for HFC PCI cards"
depends on MISDN
depends on PCI
+ depends on VIRT_TO_BUS
help
Enable support for cards with Cologne Chip AG's
HFC PCI chip.
--
1.5.6.3
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Mon, 28 Jul 2008 02:37:32 +1000
"Stephen Rothwell" <[email protected]> wrote:
> On powerpc (allyesconfig build) we get this error:
>
> drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit
> declaration of function 'virt_to_bus'
When did mISDN make it into the kernel? And which kernel tree is it in?
I don't see it in the Linux next tree....
I am very interested since we are trying to get mISDN working on the
Warp. There was no notice that they got 2.6.26 compiling.
Cheers,
Sean
On Mon, 28 Jul 2008 02:37:32 +1000
Stephen Rothwell <[email protected]> wrote:
> On powerpc (allyesconfig build) we get this error:
>
> drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'
>
> Signed-off-by: Stephen Rothwell <[email protected]>
Can we please not merge new virt_to_bus users and instead fix the actual
code to use the right functions?
On Sun, Jul 27, 2008 at 01:39:18PM -0400, Sean MacLennan wrote:
> On Mon, 28 Jul 2008 02:37:32 +1000
> "Stephen Rothwell" <[email protected]> wrote:
>
> > On powerpc (allyesconfig build) we get this error:
> >
> > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit
> > declaration of function 'virt_to_bus'
>
> When did mISDN make it into the kernel? And which kernel tree is it in?
> I don't see it in the Linux next tree....
It is there in his master branch.
>
> I am very interested since we are trying to get mISDN working on the
> Warp. There was no notice that they got 2.6.26 compiling.
>
Good to hear.
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
From: Alan Cox <[email protected]>
Date: Sun, 27 Jul 2008 18:27:09 +0100
> On Mon, 28 Jul 2008 02:37:32 +1000
> Stephen Rothwell <[email protected]> wrote:
>
> > On powerpc (allyesconfig build) we get this error:
> >
> > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'
> >
> > Signed-off-by: Stephen Rothwell <[email protected]>
>
> Can we please not merge new virt_to_bus users and instead fix the actual
> code to use the right functions?
Yes, please.
IMHO, this driver was really rushed in and that was a huge mistake.
If it had gone through linux-next we could have tidied all of this
stuff up in a less "rushed" manner.
> IMHO, this driver was really rushed in and that was a huge mistake.
> If it had gone through linux-next we could have tidied all of this
> stuff up in a less "rushed" manner.
?? This thread *is* about a build failure in linux-next.
- R.
On Sun, Jul 27, 2008 at 01:33:49PM -0700, Roland Dreier wrote:
> > IMHO, this driver was really rushed in and that was a huge mistake.
> > If it had gone through linux-next we could have tidied all of this
> > stuff up in a less "rushed" manner.
>
> ?? This thread *is* about a build failure in linux-next.
mISDN are in -linus which is part of -next and Stephens point is that if
we have had mISDN in -next then this would have been fixed before hitting
-linus. Maybe Karsten should use davem as gateway as he has anyway been
so for other isdn patches lately?
Sam
From: Roland Dreier <[email protected]>
Date: Sun, 27 Jul 2008 13:33:49 -0700
> > IMHO, this driver was really rushed in and that was a huge mistake.
> > If it had gone through linux-next we could have tidied all of this
> > stuff up in a less "rushed" manner.
>
> ?? This thread *is* about a build failure in linux-next.
The driver went directly into Linus's tree.
Stephen hit the build problem once he synced linux-next up with
Linus's current tree.
On Sun, 27 Jul 2008 18:27:09 +0100 Alan Cox <[email protected]> wrote:
>
> On Mon, 28 Jul 2008 02:37:32 +1000 Stephen Rothwell <[email protected]> wrote:
>
> > On powerpc (allyesconfig build) we get this error:
> >
> > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'
> >
> > Signed-off-by: Stephen Rothwell <[email protected]>
>
> Can we please not merge new virt_to_bus users and instead fix the actual
> code to use the right functions?
Absolutely. But I currently just want my trees to build (I am a bear of
little brain with simple needs :-))
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Roland,
On Sun, 27 Jul 2008 13:33:49 -0700 Roland Dreier <[email protected]> wrote:
>
> > IMHO, this driver was really rushed in and that was a huge mistake.
> > If it had gone through linux-next we could have tidied all of this
> > stuff up in a less "rushed" manner.
>
> ?? This thread *is* about a build failure in linux-next.
I noticed this in Linus' tree ... I did not mention linux-next.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Sam,
On Sun, 27 Jul 2008 22:43:55 +0200 Sam Ravnborg <[email protected]> wrote:
>
> On Sun, Jul 27, 2008 at 01:33:49PM -0700, Roland Dreier wrote:
> > > IMHO, this driver was really rushed in and that was a huge mistake.
> > > If it had gone through linux-next we could have tidied all of this
> > > stuff up in a less "rushed" manner.
> >
> > ?? This thread *is* about a build failure in linux-next.
> mISDN are in -linus which is part of -next and Stephens point is that if
> we have had mISDN in -next then this would have been fixed before hitting
> -linus.
Dave made that point, not me.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Dave,
On Sun, 27 Jul 2008 16:14:32 -0700 (PDT) David Miller <[email protected]> wrote:
>
> The driver went directly into Linus's tree.
>
> Stephen hit the build problem once he synced linux-next up with
> Linus's current tree.
It didn't even get as far as linux-next, I was just browsing the
bloodbath that is/was Linus' tree
(http://kisskb.ellerman.id.au/kisskb/branch/3/) :-(.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Sean,
On Sun, 27 Jul 2008 13:39:18 -0400 Sean MacLennan <[email protected]> wrote:
>
> On Mon, 28 Jul 2008 02:37:32 +1000
> "Stephen Rothwell" <[email protected]> wrote:
>
> > On powerpc (allyesconfig build) we get this error:
> >
> > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit
> > declaration of function 'virt_to_bus'
>
> When did mISDN make it into the kernel? And which kernel tree is it in?
> I don't see it in the Linux next tree....
Its not in linux-next (will be today). It went straight into Linus' tree
late last week.
> I am very interested since we are trying to get mISDN working on the
> Warp. There was no notice that they got 2.6.26 compiling.
It won't even build on powerpc64, powercp32 should at least build.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Sun, Jul 27, 2008 at 12:56:04PM -0700, David Miller wrote:
> Yes, please.
>
> IMHO, this driver was really rushed in and that was a huge mistake.
> If it had gone through linux-next we could have tidied all of this
> stuff up in a less "rushed" manner.
Or just reviewed in at least some way..