2008-07-27 12:34:34

by Niels de Vos

Subject: [RESEND] [PATCH] linux/fs.h should include linux/path.h

<linux/fs.h> defines 'struct file' which uses 'struct path'. However
<linux/path.h> is not being included.

Signed-off-by: Niels de Vos <[email protected]>

---
diff --git a/include/linux/fs.h b/include/linux/fs.h
index d8e2762..a14f1c4 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -289,6 +289,7 @@ extern int dir_notify_enable;
#include <linux/mutex.h>
#include <linux/capability.h>
#include <linux/semaphore.h>
+#include <linux/path.h>

#include <asm/atomic.h>
#include <asm/byteorder.h>

2008-07-27 15:52:20

by Alexey Dobriyan

Subject: Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h

On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
> <linux/path.h> is not being included.

> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
> #include <linux/mutex.h>
> #include <linux/capability.h>
> #include <linux/semaphore.h>
> +#include <linux/path.h>

You see compilation breakage?

2008-07-27 15:59:38

by Adrian Bunk

Subject: Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h

On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
> <linux/path.h> is not being included.
>
> Signed-off-by: Niels de Vos <[email protected]>
>
> ---
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index d8e2762..a14f1c4 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
> #include <linux/mutex.h>
> #include <linux/capability.h>
> #include <linux/semaphore.h>
> +#include <linux/path.h>
>...

This #include was recently added a few lines above.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2008-07-27 16:03:36

by Niels de Vos

Subject: Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h

On Sun, Jul 27, 2008 at 5:58 PM, Adrian Bunk <[email protected]> wrote:
> On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
>> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
>> <linux/path.h> is not being included.
>>
>> Signed-off-by: Niels de Vos <[email protected]>
>>
>> ---
>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>> index d8e2762..a14f1c4 100644
>> --- a/include/linux/fs.h
>> +++ b/include/linux/fs.h
>> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
>> #include <linux/mutex.h>
>> #include <linux/capability.h>
>> #include <linux/semaphore.h>
>> +#include <linux/path.h>
>>...
>
> This #include was recently added a few lines above.

Okay, looks like I've missed that commit.

Thanks, Niels