2008-07-30 09:57:17

by Florian Fainelli

[permalink] [raw]
Subject: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

Sorry for the previous version, I forgot reading that .gitignore files
should be per-directory in this case.
--
From: Florian Fainelli <[email protected]>
Subject: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

Add drivers/video/console/promcon_tbl.c to the list of ignored files.
This file is generated by conmakehash against drivers/video/console/prom.uni.

Signed-off-by: Florian Fainelli <[email protected]>
---
diff --git a/drivers/video/console/.gitignore b/drivers/video/console/.gitignore
new file mode 100644
index 0000000..ad0ad9b
--- /dev/null
+++ b/drivers/video/console/.gitignore
@@ -0,0 +1,2 @@
+# Generated conmakehash files
+drivers/video/console/promcon_tbl.c


2008-07-30 11:25:45

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

On Wed, Jul 30, 2008 at 11:56:13AM +0200, Florian Fainelli wrote:
> Sorry for the previous version, I forgot reading that .gitignore files
> should be per-directory in this case.
> --
> From: Florian Fainelli <[email protected]>
> Subject: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file
>
> Add drivers/video/console/promcon_tbl.c to the list of ignored files.
> This file is generated by conmakehash against drivers/video/console/prom.uni.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> diff --git a/drivers/video/console/.gitignore b/drivers/video/console/.gitignore
> new file mode 100644
> index 0000000..ad0ad9b
> --- /dev/null
> +++ b/drivers/video/console/.gitignore
> @@ -0,0 +1,2 @@
> +# Generated conmakehash files
> +drivers/video/console/promcon_tbl.c

Did you test this?
I recall you should specify filenames relative to the
path of .gitignore.

Sam

2008-07-30 11:30:41

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

Hi Sam,

Le Wednesday 30 July 2008 13:26:20 Sam Ravnborg, vous avez ?crit?:
> Did you test this?
> I recall you should specify filenames relative to the
> path of .gitignore.

Yes it works here with git client version 1.5.6.2.

2008-07-30 15:42:31

by Adrian Bunk

[permalink] [raw]
Subject: Re: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

On Wed, Jul 30, 2008 at 01:26:20PM +0200, Sam Ravnborg wrote:
> On Wed, Jul 30, 2008 at 11:56:13AM +0200, Florian Fainelli wrote:
> > Sorry for the previous version, I forgot reading that .gitignore files
> > should be per-directory in this case.
> > --
> > From: Florian Fainelli <[email protected]>
> > Subject: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file
> >
> > Add drivers/video/console/promcon_tbl.c to the list of ignored files.
> > This file is generated by conmakehash against drivers/video/console/prom.uni.
> >
> > Signed-off-by: Florian Fainelli <[email protected]>
> > ---
> > diff --git a/drivers/video/console/.gitignore b/drivers/video/console/.gitignore
> > new file mode 100644
> > index 0000000..ad0ad9b
> > --- /dev/null
> > +++ b/drivers/video/console/.gitignore
> > @@ -0,0 +1,2 @@
> > +# Generated conmakehash files
> > +drivers/video/console/promcon_tbl.c
>
> Did you test this?
> I recall you should specify filenames relative to the
> path of .gitignore.

According to the manpage both should work.

But I'd personally prefer it without a path since that's more robust in
case of directory moves.

> Sam

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2008-07-30 16:02:47

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

On Wed, Jul 30, 2008 at 06:41:27PM +0300, Adrian Bunk wrote:
> On Wed, Jul 30, 2008 at 01:26:20PM +0200, Sam Ravnborg wrote:
> > On Wed, Jul 30, 2008 at 11:56:13AM +0200, Florian Fainelli wrote:
> > > Sorry for the previous version, I forgot reading that .gitignore files
> > > should be per-directory in this case.
> > > --
> > > From: Florian Fainelli <[email protected]>
> > > Subject: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file
> > >
> > > Add drivers/video/console/promcon_tbl.c to the list of ignored files.
> > > This file is generated by conmakehash against drivers/video/console/prom.uni.
> > >
> > > Signed-off-by: Florian Fainelli <[email protected]>
> > > ---
> > > diff --git a/drivers/video/console/.gitignore b/drivers/video/console/.gitignore
> > > new file mode 100644
> > > index 0000000..ad0ad9b
> > > --- /dev/null
> > > +++ b/drivers/video/console/.gitignore
> > > @@ -0,0 +1,2 @@
> > > +# Generated conmakehash files
> > > +drivers/video/console/promcon_tbl.c
> >
> > Did you test this?
> > I recall you should specify filenames relative to the
> > path of .gitignore.
>
> According to the manpage both should work.
>
> But I'd personally prefer it without a path since that's more robust in
> case of directory moves.
I tested it here and it only worked for me without the path.

Florian - please drop the path and resend.

Thanks,
Sam

2008-07-30 21:31:52

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

Hello Sam,

Le Wednesday 30 July 2008 17:59:55 Sam Ravnborg, vous avez ?crit?:
> I tested it here and it only worked for me without the path.
>
> Florian - please drop the path and resend.

Patch below, thanks.
--
From: Florian Fainelli <[email protected]>
Subject: [PATCH -next V3] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

Add drivers/video/console/promcon_tbl.c to the list of ignored files.
This file is generated by conmakehash against drivers/video/console/prom.uni.

Signed-off-by: Florian Fainelli <[email protected]>
---
diff --git a/drivers/video/console/.gitignore b/drivers/video/console/.gitignore
new file mode 100644
index 0000000..0c258b4
--- /dev/null
+++ b/drivers/video/console/.gitignore
@@ -0,0 +1,2 @@
+# conmakehash generated file
+promcon_tbl.c

2008-07-30 23:50:25

by David Miller

[permalink] [raw]
Subject: Re: [PATCH -next V2] Ignore drivers/video/console/promcon_tbl.c conmakehash generated file

From: Florian Fainelli <[email protected]>
Date: Wed, 30 Jul 2008 23:30:58 +0200

> Le Wednesday 30 July 2008 17:59:55 Sam Ravnborg, vous avez ?crit?:
> > I tested it here and it only worked for me without the path.
> >
> > Florian - please drop the path and resend.
>
> Patch below, thanks.

Applied, thank Florian.