2008-08-02 08:07:55

by Alexander Beregalov

[permalink] [raw]
Subject: [PATCH] omfs: fix warning

From: Alexander Beregalov <[email protected]>

omfs: fix warnings

fs/omfs/inode.c:495: warning: format '%llx' expects type 'long long
unsigned int', but argument 2 has type 'u64'
fs/omfs/inode.c:495: warning: format '%llx' expects type 'long
long unsigned int', but argument 3 has type '__be64'

Signed-off-by: Alexander Beregalov <[email protected]>
Cc: Bob Copeland <[email protected]>

---

fs/omfs/inode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index d865f55..a95fe59 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -492,7 +492,8 @@ static int omfs_fill_super(struct super_block *sb, void *data, int silent)
if (sbi->s_num_blocks != be64_to_cpu(omfs_rb->r_num_blocks)) {
printk(KERN_ERR "omfs: block count discrepancy between "
"super and root blocks (%llx, %llx)\n",
- sbi->s_num_blocks, be64_to_cpu(omfs_rb->r_num_blocks));
+ (unsigned long long)sbi->s_num_blocks,
+ (unsigned long long)be64_to_cpu(omfs_rb->r_num_blocks));
goto out_brelse_bh2;
}


2008-08-02 13:24:48

by Bob Copeland

[permalink] [raw]
Subject: Re: [PATCH] omfs: fix warning

On Sat, Aug 02, 2008 at 12:07:25PM +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <[email protected]>
>
> omfs: fix warnings
>
> fs/omfs/inode.c:495: warning: format '%llx' expects type 'long long
> unsigned int', but argument 2 has type 'u64'
> fs/omfs/inode.c:495: warning: format '%llx' expects type 'long
> long unsigned int', but argument 3 has type '__be64'
>
> Signed-off-by: Alexander Beregalov <[email protected]>
> Cc: Bob Copeland <[email protected]>

Thanks!

Acked-by: Bob Copeland <[email protected]>

(And I'm downloading cross compilers as I type this.)

Andrew, should I continue to send omfs patches through you, or do I need
to publish a git repo?

> "super and root blocks (%llx, %llx)\n",
> - sbi->s_num_blocks, be64_to_cpu(omfs_rb->r_num_blocks));
> + (unsigned long long)sbi->s_num_blocks,
> + (unsigned long long)be64_to_cpu(omfs_rb->r_num_blocks));
> goto out_brelse_bh2;

--
Bob Copeland %% http://www.bobcopeland.com