2008-08-02 20:01:36

by Oliver Pinter

[permalink] [raw]
Subject: [RFC, 2.6.26.2-rc1] HID: fix memory leak in hidraw_release

>From 4db1c62c9991e62b441672db7f227e722776adc4 Mon Sep 17 00:00:00 2001
From: Jiri Kosina <[email protected]>
Date: Tue, 24 Jun 2008 14:45:27 +0200
Subject: [PATCH] HID: fix memory leak in hidraw_release

[ Upstream commit 4db1c62c9991e62b441672db7f227e722776adc4 ]

hidraw_release() forgot to free the linked list structure, causing memory
leak.

Reported-by: Juan Marcos Diez Esteban <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
CC: Oliver Pinter <[email protected]>

diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index 0c6b4d4..8ecd775 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -211,6 +211,8 @@ static int hidraw_release(struct inode * inode, struct file * file)
kfree(list->hidraw);
}

+ kfree(list);
+
return 0;
}