2008-08-03 04:34:59

by Yoshinori Sato

[permalink] [raw]
Subject: [PATCH 0/3] h8300 update timer handler

h8300 new timer handlers.

1/3 - new timer handler
2/3 - delete obsolute files
3/3 - misc update

arch/h8300/Kconfig.cpu | 115 ++++++++++-------------
arch/h8300/kernel/Makefile | 2 +-
arch/h8300/kernel/time.c | 5 +-
arch/h8300/kernel/timer/Makefile | 6 ++
arch/h8300/kernel/timer/itu.c | 83 +++++++++++++++++
arch/h8300/kernel/timer/timer16.c | 78 ++++++++++++++++
arch/h8300/kernel/timer/timer8.c | 103 +++++++++++++++++++++
arch/h8300/kernel/timer/tpu.c | 102 +++++++++++++++++++++
arch/h8300/platform/h8300h/aki3068net/Makefile | 1 -
arch/h8300/platform/h8300h/aki3068net/timer.c | 51 -----------
arch/h8300/platform/h8300h/generic/Makefile | 1 -
arch/h8300/platform/h8300h/generic/timer.c | 95 -------------------
arch/h8300/platform/h8300h/h8max/Makefile | 1 -
arch/h8300/platform/h8300h/h8max/timer.c | 52 -----------
arch/h8300/platform/h8s/edosk2674/Makefile | 1 -
arch/h8300/platform/h8s/edosk2674/timer.c | 54 -----------
arch/h8300/platform/h8s/generic/Makefile | 1 -
arch/h8300/platform/h8s/generic/timer.c | 53 -----------
include/asm-h8300/io.h | 34 +++++++
include/asm-h8300/timer.h | 25 +++++
20 files changed, 486 insertions(+), 377 deletions(-)
create mode 100644 arch/h8300/kernel/timer/Makefile
create mode 100644 arch/h8300/kernel/timer/itu.c
create mode 100644 arch/h8300/kernel/timer/timer16.c
create mode 100644 arch/h8300/kernel/timer/timer8.c
create mode 100644 arch/h8300/kernel/timer/tpu.c
delete mode 100644 arch/h8300/platform/h8300h/aki3068net/timer.c
delete mode 100644 arch/h8300/platform/h8300h/generic/timer.c
delete mode 100644 arch/h8300/platform/h8300h/h8max/timer.c
delete mode 100644 arch/h8300/platform/h8s/edosk2674/timer.c
delete mode 100644 arch/h8300/platform/h8s/generic/timer.c
create mode 100644 include/asm-h8300/timer.h

--
Yoshinori Sato
<[email protected]>


2008-08-04 23:17:17

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 0/3] h8300 update timer handler

On Sun, 03 Aug 2008 00:34:06 -0400 Yoshinori Sato <[email protected]> wrote:

> h8300 new timer handlers.
>
> 1/3 - new timer handler
> 2/3 - delete obsolute files
> 3/3 - misc update

Could you please always describe your changes more completely?

We are provided no explanation of why the old code was removed, why the
new code is added, what problems were fixed, etc.

The way these patches have been documented, I have no way of knowing
whether or not they should be merged into 2.6.27. Do you think they
should be? If so, why?

Thanks.

2008-08-05 19:53:48

by Yoshinori Sato

[permalink] [raw]
Subject: Re: [PATCH 0/3] h8300 update timer handler

At Mon, 4 Aug 2008 16:16:53 -0700,
Andrew Morton wrote:
>
> On Sun, 03 Aug 2008 00:34:06 -0400 Yoshinori Sato <[email protected]> wrote:
>
> > h8300 new timer handlers.
> >
> > 1/3 - new timer handler
> > 2/3 - delete obsolute files
> > 3/3 - misc update
>
> Could you please always describe your changes more completely?
>
> We are provided no explanation of why the old code was removed, why the
> new code is added, what problems were fixed, etc.

I added new target.
Because duplicate same timer handler.
And old code little complex.

> The way these patches have been documented, I have no way of knowing
> whether or not they should be merged into 2.6.27. Do you think they
> should be? If so, why?

This patch need new target only.
I don't early.

> Thanks.

--
Yoshinori Sato
<[email protected]>