2008-08-06 13:32:01

by Karsten Keil

Subject: [PATCH 3/3] Fix lockdep warning

use correct dynamic spinlock init function.

Signed-off-by: Karsten Keil <[email protected]>
---
drivers/isdn/mISDN/tei.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/mISDN/tei.c b/drivers/isdn/mISDN/tei.c
index 6fbae42..d8af45c 100644
--- a/drivers/isdn/mISDN/tei.c
+++ b/drivers/isdn/mISDN/tei.c
@@ -1287,7 +1287,7 @@ create_teimanager(struct mISDNdevice *dev)
if (!mgr)
return -ENOMEM;
INIT_LIST_HEAD(&mgr->layer2);
- mgr->lock = __RW_LOCK_UNLOCKED(mgr->lock);
+ rwlock_init(&mgr->lock);
skb_queue_head_init(&mgr->sendq);
mgr->nextid = 1;
mgr->lastid = MISDN_ID_NONE;
--
1.5.6.4

2008-08-06 15:33:12

by Randy Dunlap

Subject: Re: [PATCH 3/3] Fix lockdep warning

On Wed, 6 Aug 2008 15:30:31 +0200 (CEST) Karsten Keil wrote:

> use correct dynamic spinlock init function.
>
> Signed-off-by: Karsten Keil <[email protected]>

Hi,

It would be a Really Good Thing if we could look at the subject line
and see that this is for an ISDN driver instead of something else,
like even the general lockdep framework.

The Perfect Patch (http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt)
section 2.b. discusses this, but it isn't quite strong enough. ;)


Thanks.

> ---
> drivers/isdn/mISDN/tei.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/isdn/mISDN/tei.c b/drivers/isdn/mISDN/tei.c
> index 6fbae42..d8af45c 100644
> --- a/drivers/isdn/mISDN/tei.c
> +++ b/drivers/isdn/mISDN/tei.c
> @@ -1287,7 +1287,7 @@ create_teimanager(struct mISDNdevice *dev)
> if (!mgr)
> return -ENOMEM;
> INIT_LIST_HEAD(&mgr->layer2);
> - mgr->lock = __RW_LOCK_UNLOCKED(mgr->lock);
> + rwlock_init(&mgr->lock);
> skb_queue_head_init(&mgr->sendq);
> mgr->nextid = 1;
> mgr->lastid = MISDN_ID_NONE;
> --

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/