2008-08-06 15:33:59

by Peter Oruba

Subject: [patch 2/5] [PATCH 2/5] x86: Minor correction to header file

Signed-off-by: Peter Oruba <[email protected]>
---
include/asm-x86/microcode.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-x86/microcode.h b/include/asm-x86/microcode.h
index 072bef1..fb08022 100644
--- a/include/asm-x86/microcode.h
+++ b/include/asm-x86/microcode.h
@@ -1,5 +1,5 @@
-extern int microcode_init(void *opaque, struct module *module);
-extern void microcode_exit(void);
+int microcode_init(void *opaque, struct module *module);
+void microcode_exit(void);

struct microcode_header_intel {
unsigned int hdrver;
--
1.5.4.5

2008-08-11 19:25:40

by Ingo Molnar

Subject: Re: [patch 2/5] [PATCH 2/5] x86: Minor correction to header file

* Peter Oruba <[email protected]> wrote:

> Signed-off-by: Peter Oruba <[email protected]>
> ---
> include/asm-x86/microcode.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/asm-x86/microcode.h b/include/asm-x86/microcode.h
> index 072bef1..fb08022 100644
> --- a/include/asm-x86/microcode.h
> +++ b/include/asm-x86/microcode.h
> @@ -1,5 +1,5 @@
> -extern int microcode_init(void *opaque, struct module *module);
> -extern void microcode_exit(void);
> +int microcode_init(void *opaque, struct module *module);
> +void microcode_exit(void);

why? extern is the typical way to specify interfaces.

Ingo