2008-08-06 20:19:55

by Geert Uytterhoeven

Subject: [PATCH] m68k/amiserial: fix fallout of tty break handling rework

commit 9e98966c7bb94355689478bc84cc3e0c190f977e (tty: rework break handling)
forgot to update one exit point of rs_break() in the Amiga serial driver.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/char/amiserial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/char/amiserial.c
+++ b/drivers/char/amiserial.c
@@ -1254,7 +1254,7 @@ static int rs_break(struct tty_struct *t
unsigned long flags;

if (serial_paranoia_check(info, tty->name, "rs_break"))
- return;
+ return -EINVAL;

local_irq_save(flags);
if (break_state == -1)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2008-08-06 22:29:20

by Alan Cox

Subject: Re: [PATCH] m68k/amiserial: fix fallout of tty break handling rework

On Wed, Aug 06, 2008 at 10:19:39PM +0200, Geert Uytterhoeven wrote:
> commit 9e98966c7bb94355689478bc84cc3e0c190f977e (tty: rework break handling)
> forgot to update one exit point of rs_break() in the Amiga serial driver.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Alan Cox <[email protected]>