2008-08-03 16:50:53

by Marcin Ślusarz

Subject: [PATCH] usb: cdc-acm: flags passed to spin_lock_irqsave must be unsigned

gcc warned about it:
drivers/usb/class/cdc-acm.c: In function 'acm_waker':
drivers/usb/class/cdc-acm.c:527: warning: comparison of distinct pointer types lacks a cast
drivers/usb/class/cdc-acm.c:529: warning: comparison of distinct pointer types lacks a cast

Signed-off-by: Marcin Slusarz <[email protected]>
Cc: Oliver Neukum <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
drivers/usb/class/cdc-acm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 0725b18..a92395b 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -512,7 +512,7 @@ static void acm_softint(struct work_struct *work)
static void acm_waker(struct work_struct *waker)
{
struct acm *acm = container_of(waker, struct acm, waker);
- long flags;
+ unsigned long flags;
int rv;

rv = usb_autopm_get_interface(acm->control);
--
1.5.4.5

2008-08-07 02:12:30

by Greg KH

Subject: Re: [PATCH] usb: cdc-acm: flags passed to spin_lock_irqsave must be unsigned

On Sun, Aug 03, 2008 at 06:50:14PM +0200, Marcin Slusarz wrote:
> gcc warned about it:
> drivers/usb/class/cdc-acm.c: In function 'acm_waker':
> drivers/usb/class/cdc-acm.c:527: warning: comparison of distinct pointer types lacks a cast
> drivers/usb/class/cdc-acm.c:529: warning: comparison of distinct pointer types lacks a cast
>
> Signed-off-by: Marcin Slusarz <[email protected]>
> Cc: Oliver Neukum <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>

Just got this fix from someone else first, sorry, but thanks for the
patch.

greg k-h