2008-08-07 22:25:20

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] pci-calgary: fix function declaration

From: Randy Dunlap <[email protected]>
cc: [email protected], [email protected]

Fix function declaration:

linux-next-20080807/arch/x86/kernel/pci-calgary_64.c:1353:36: warning: non-ANSI function declaration of function 'get_tce_space_from_tar'

Signed-off-by: Randy Dunlap <[email protected]>
---
arch/x86/kernel/pci-calgary_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20080807.orig/arch/x86/kernel/pci-calgary_64.c
+++ linux-next-20080807/arch/x86/kernel/pci-calgary_64.c
@@ -1350,7 +1350,7 @@ static void calgary_init_bitmap_from_tce
* Function for kdump case. Get the tce tables from first kernel
* by reading the contents of the base adress register of calgary iommu
*/
-static void get_tce_space_from_tar()
+static void get_tce_space_from_tar(void)
{
int bus;
void __iomem *target;


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/


2008-08-08 07:17:30

by Muli Ben-Yehuda

[permalink] [raw]
Subject: Re: [PATCH] pci-calgary: fix function declaration

On Thu, Aug 07, 2008 at 03:14:55PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
> cc: [email protected], [email protected]
>
> Fix function declaration:
>
> linux-next-20080807/arch/x86/kernel/pci-calgary_64.c:1353:36: warning: non-ANSI function declaration of function 'get_tce_space_from_tar'
>
> Signed-off-by: Randy Dunlap <[email protected]>

Acked-by: Muli Ben-Yehuda <[email protected]>

Cheers,
Muli
--
Workshop on I/O Virtualization (WIOV '08)
Co-located with OSDI '08, Dec 2008, San Diego, CA
http://www.usenix.org/wiov08

2008-08-11 16:50:50

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] pci-calgary: fix function declaration


* Muli Ben-Yehuda <[email protected]> wrote:

> On Thu, Aug 07, 2008 at 03:14:55PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <[email protected]>
> > cc: [email protected], [email protected]
> >
> > Fix function declaration:
> >
> > linux-next-20080807/arch/x86/kernel/pci-calgary_64.c:1353:36: warning: non-ANSI function declaration of function 'get_tce_space_from_tar'
> >
> > Signed-off-by: Randy Dunlap <[email protected]>
>
> Acked-by: Muli Ben-Yehuda <[email protected]>

applied to tip/x86/urgent - thanks.

Ingo