2008-08-17 01:34:36

by Alexander Beregalov

Subject: [PATCH] security.h: fix build failure

From: Alexander Beregalov <[email protected]>

security.h: fix build failure

include/linux/security.h: In function 'security_ptrace_traceme':
include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)


Signed-off-by: Alexander Beregalov <[email protected]>
---

include/linux/security.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/security.h b/include/linux/security.h
index 2ee5ecf..80c4d00 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
return cap_ptrace_may_access(child, mode);
}

-static inline int security_ptrace_traceme(struct task_struct *child)
+static inline int security_ptrace_traceme(struct task_struct *parent)
{
return cap_ptrace_traceme(parent);
}

2008-08-17 09:25:37

by Ingo Molnar

Subject: Re: [PATCH] security.h: fix build failure

* Alexander Beregalov <[email protected]> wrote:

> From: Alexander Beregalov <[email protected]>
>
> security.h: fix build failure
>
> include/linux/security.h: In function 'security_ptrace_traceme':
> include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)

i just triggered this too on today's -git with this config:

http://redhat.com/~mingo/misc/config-Sun_Aug_17_11_02_11_CEST_2008.bad

and your fix solves it.

Tested-by: Ingo Molnar <[email protected]>

Ingo

2008-08-17 12:45:26

by James Morris

Subject: Re: [PATCH] security.h: fix build failure

On Sun, 17 Aug 2008, Alexander Beregalov wrote:

> From: Alexander Beregalov <[email protected]>
>
> security.h: fix build failure
>
> include/linux/security.h: In function 'security_ptrace_traceme':
> include/linux/security.h:1760: error: 'parent' undeclared (first use in this function)
>
>
> Signed-off-by: Alexander Beregalov <[email protected]>

Acked-by: James Morris <[email protected]>


> ---
>
> include/linux/security.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 2ee5ecf..80c4d00 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
> return cap_ptrace_may_access(child, mode);
> }
>
> -static inline int security_ptrace_traceme(struct task_struct *child)
> +static inline int security_ptrace_traceme(struct task_struct *parent)
> {
> return cap_ptrace_traceme(parent);
> }
>

--
James Morris
<[email protected]>

2008-08-17 13:10:21

by James Morris

Subject: [GIT] Re: [PATCH] security.h: fix build failure

There's a pullable version here:

The following changes since commit
b09c3e3f1710b554348c98e78fbf4a661918779a:
Huang Weiyi (1):
removed unused #include <version.h>

are available in the git repository at:


git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6 for-linus

Alexander Beregalov (1):
security.h: fix build failure

include/linux/security.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)




--
James Morris
<[email protected]>