2008-08-19 13:47:50

by Adrian Bunk

Subject: [2.6 patch] make kprobes.c:kretprobe_table_lock() static

This patch makes the needlessly global kretprobe_table_lock() static.

Signed-off-by: Adrian Bunk <[email protected]>

---
7282c07a74451fca15cad3b8b1626e0b9ec0ba17
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 75bc2cd..8b57a25 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -404,7 +404,7 @@ void kretprobe_hash_lock(struct task_struct *tsk,
spin_lock_irqsave(hlist_lock, *flags);
}

-void kretprobe_table_lock(unsigned long hash, unsigned long *flags)
+static void kretprobe_table_lock(unsigned long hash, unsigned long *flags)
{
spinlock_t *hlist_lock = kretprobe_table_lock_ptr(hash);
spin_lock_irqsave(hlist_lock, *flags);

2008-08-19 14:03:34

by Ananth N Mavinakayanahalli

Subject: Re: [2.6 patch] make kprobes.c:kretprobe_table_lock() static

On Tue, Aug 19, 2008 at 04:47:06PM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global kretprobe_table_lock() static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Ananth N Mavinakayanahalli <[email protected]>

Thanks Adrian.

> ---
> 7282c07a74451fca15cad3b8b1626e0b9ec0ba17
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 75bc2cd..8b57a25 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -404,7 +404,7 @@ void kretprobe_hash_lock(struct task_struct *tsk,
> spin_lock_irqsave(hlist_lock, *flags);
> }
>
> -void kretprobe_table_lock(unsigned long hash, unsigned long *flags)
> +static void kretprobe_table_lock(unsigned long hash, unsigned long *flags)
> {
> spinlock_t *hlist_lock = kretprobe_table_lock_ptr(hash);
> spin_lock_irqsave(hlist_lock, *flags);