2008-08-23 11:58:57

by David Witbrodt

[permalink] [raw]
Subject: Re: HPET regression in 2.6.26 versus 2.6.25 -- found another user with the same regression



> please send out after booting with hpet=disable
> lspci -tv
> lspci -vvxxx

Info attached:


Attachments:
lspci-2.6.27-rc4-hpet-disable.txt (30.76 kB)

2008-08-23 13:37:53

by Ingo Molnar

[permalink] [raw]
Subject: Re: HPET regression in 2.6.26 versus 2.6.25 -- found another user with the same regression


David,

could you try the debug patch below ontop of latest tip/master:

http://people.redhat.com/mingo/tip.git/README

the patch forcibly ignores resource conflicts and reports them. This
will likely break some system - but if your hpet troubles are due to
resource conflicts then this patch would make the kernel boot up fine on
your system by default, with a working hpet.

You should also be getting a printout and a warning in the dmesg in that
case.

Ingo

------------>
>From 092990e259a462d39f1d8e9cd542898632b95fde Mon Sep 17 00:00:00 2001
From: Ingo Molnar <[email protected]>
Date: Sat, 23 Aug 2008 15:33:51 +0200
Subject: [PATCH] debug hack: ignore resource conflicts

Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/resource.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index f5b518e..8419d56 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -156,6 +156,7 @@ static struct resource * __request_resource(struct resource *root, struct resour
for (;;) {
tmp = *p;
if (!tmp || tmp->start > end) {
+insert:
new->sibling = tmp;
*p = new;
new->parent = root;
@@ -164,7 +165,9 @@ static struct resource * __request_resource(struct resource *root, struct resour
p = &tmp->sibling;
if (tmp->end < start)
continue;
- return tmp;
+ printk("ignoring resource conflict between %s/{%p..%p} and %s/{%p..%p}\n", new->name, (void *)new->start, (void *)new->end, tmp->name, (void *)tmp->start, (void *)tmp->end);
+ WARN_ON(1);
+ goto insert;
}
}

2008-08-23 15:04:45

by Ingo Molnar

[permalink] [raw]
Subject: Re: HPET regression in 2.6.26 versus 2.6.25 -- found another user with the same regression


* Ingo Molnar <[email protected]> wrote:

> could you try the debug patch below ontop of latest tip/master:

please use the replacement debug patch below. (the previous one was
buggy, it would likely lock up because it iterated incorrectly.)

[ and i'd also like to stress that this isnt a solution, this is a debug
hack that can lead to a solution. ]

Ingo

-------------->
>From dc1c9cafd20edacb14e902c5ee72547f14c12545 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <[email protected]>
Date: Sat, 23 Aug 2008 15:33:51 +0200
Subject: [PATCH] debug: ignore resource conflicts

---
kernel/resource.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index f5b518e..45877ec 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -156,15 +156,19 @@ static struct resource * __request_resource(struct resource *root, struct resour
for (;;) {
tmp = *p;
if (!tmp || tmp->start > end) {
+insert:
new->sibling = tmp;
*p = new;
new->parent = root;
return NULL;
}
- p = &tmp->sibling;
- if (tmp->end < start)
+ if (tmp->end < start) {
+ p = &tmp->sibling;
continue;
- return tmp;
+ }
+ printk("ignoring resource conflict between %s/{%p..%p} and %s/{%p..%p}\n", new->name, (void *)new->start, (void *)new->end, tmp->name, (void *)tmp->start, (void *)tmp->end);
+ WARN_ON(1);
+ goto insert;
}
}

2008-08-23 17:51:42

by Yinghai Lu

[permalink] [raw]
Subject: Re: HPET regression in 2.6.26 versus 2.6.25 -- found another user with the same regression

On Sat, Aug 23, 2008 at 4:58 AM, David Witbrodt <[email protected]> wrote:
>
>
>> please send out after booting with hpet=disable
>> lspci -tv
>> lspci -vvxxx
>
> Info attached:

00:14.0 SMBus: ATI Technologies Inc SBx00 SMBus Controller (rev 13)
Subsystem: Elitegroup Computer Systems Device 2621
Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx+
Status: Cap+ 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
Region 0: I/O ports at fa00 [size=16]
Region 1: Memory at 80000000 (32-bit, non-prefetchable) [size=1K]
Capabilities: [b0] HyperTransport: MSI Mapping Enable- Fixed+
Kernel driver in use: piix4_smbus
00: 02 10 85 43 03 04 30 02 13 00 05 0c 00 00 80 00
10: 01 fa 00 00 00 00 00 80 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 19 10 21 26
30: 00 00 00 00 b0 00 00 00 00 00 00 00 00 00 00 00
40: d4 3b 00 05 00 00 00 00 0f ff 00 00 00 00 00 00
50: f0 01 f0 0e f0 0f f0 07 11 0b f0 0f 00 00 00 00
60: 01 00 24 00 bf fd de 8f 3f 90 00 00 20 00 00 00
70: 00 01 00 00 08 00 c0 fe ff 6e 00 00 00 00 f0 0f
80: f0 0a f0 0f 00 00 00 00 00 00 00 00 8c 00 00 80
90: 01 fa 00 00 fa de ff 00 00 00 00 00 00 00 00 00
a0: 00 00 ff ff ff ff f0 08 ff fd 12 02 16 7b 20 00
b0: 08 00 02 a8 00 00 00 00 00 00 00 00 f0 0f 08 1a
c0: ff ff ff ff 00 00 00 00 00 00 00 00 00 00 00 00
d0: 00 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00
e0: 20 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
f0: d8 0c 00 00 00 00 44 00 00 00 00 00 aa 00 10 01

it seems kernel update BAR1 from 0xfed00000 to 0x80000000 after it can
not give 0xfed00000 to that device.

please try attached patch, and send out lspci -vvxxxx again.

YH


Attachments:
(No filename) (1.68 kB)
hpet_in_bar1.patch (1.33 kB)
Download all attachments