2008-08-24 15:45:33

by Oleg Nesterov

Subject: [PATCH 4/4] pid_ns: kill the now unused task_child_reaper()

task_child_reaper() has no callers anymore, kill it.

Signed-off-by: Oleg Nesterov <[email protected]>

--- 2.6.27-rc4/include/linux/pid_namespace.h~4_KILL_HELPER 2008-07-30 13:12:48.000000000 +0400
+++ 2.6.27-rc4/include/linux/pid_namespace.h 2008-08-24 19:33:12.000000000 +0400
@@ -84,12 +84,6 @@ static inline struct pid_namespace *task
return tsk->nsproxy->pid_ns;
}

-static inline struct task_struct *task_child_reaper(struct task_struct *tsk)
-{
- BUG_ON(tsk != current);
- return tsk->nsproxy->pid_ns->child_reaper;
-}
-
void pidhash_init(void);
void pidmap_init(void);

2008-08-27 02:39:12

by Serge E. Hallyn

Subject: Re: [PATCH 4/4] pid_ns: kill the now unused task_child_reaper()

Quoting Oleg Nesterov ([email protected]):
> task_child_reaper() has no callers anymore, kill it.
>
> Signed-off-by: Oleg Nesterov <[email protected]>

Acked-by: Serge Hallyn <[email protected]>

> --- 2.6.27-rc4/include/linux/pid_namespace.h~4_KILL_HELPER 2008-07-30 13:12:48.000000000 +0400
> +++ 2.6.27-rc4/include/linux/pid_namespace.h 2008-08-24 19:33:12.000000000 +0400
> @@ -84,12 +84,6 @@ static inline struct pid_namespace *task
> return tsk->nsproxy->pid_ns;
> }
>
> -static inline struct task_struct *task_child_reaper(struct task_struct *tsk)
> -{
> - BUG_ON(tsk != current);
> - return tsk->nsproxy->pid_ns->child_reaper;
> -}
> -
> void pidhash_init(void);
> void pidmap_init(void);
>

2008-08-27 11:41:19

by Pavel Emelyanov

Subject: Re: [PATCH 4/4] pid_ns: kill the now unused task_child_reaper()

Oleg Nesterov wrote:
> task_child_reaper() has no callers anymore, kill it.
>
> Signed-off-by: Oleg Nesterov <[email protected]>

Acked-by: Pavel Emelyanov <[email protected]>

2008-08-27 18:13:41

by Sukadev Bhattiprolu

Subject: Re: [PATCH 4/4] pid_ns: kill the now unused task_child_reaper()

Oleg Nesterov [[email protected]] wrote:
| task_child_reaper() has no callers anymore, kill it.
|
| Signed-off-by: Oleg Nesterov <[email protected]>

Acked-by: Sukadev Bhattiprolu <[email protected]>