2008-08-25 02:23:58

by Li Zefan

Subject: [PATCH] devcgroup: remove unused variable

Signed-off-by: Li Zefan <[email protected]>
---
security/device_cgroup.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/security/device_cgroup.c b/security/device_cgroup.c
index 9c625f6..d5c15a7 100644
--- a/security/device_cgroup.c
+++ b/security/device_cgroup.c
@@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
struct dev_cgroup *cur_devcgroup;
const char *b;
char *endp;
- int retval = 0, count;
+ int count;
struct dev_whitelist_item wh;

if (!capable(CAP_SYS_ADMIN))
@@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
}

handle:
- retval = 0;
switch (filetype) {
case DEVCG_ALLOW:
if (!parent_has_perm(devcgroup, &wh))
--
1.5.4.rc3

2008-08-25 16:44:15

by Serge E. Hallyn

Subject: Re: [PATCH] devcgroup: remove unused variable

Quoting Li Zefan ([email protected]):
>
> Signed-off-by: Li Zefan <[email protected]>

Yup.

Acked-by: Serge Hallyn <[email protected]>

thanks,
-serge

> ---
> security/device_cgroup.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/security/device_cgroup.c b/security/device_cgroup.c
> index 9c625f6..d5c15a7 100644
> --- a/security/device_cgroup.c
> +++ b/security/device_cgroup.c
> @@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
> struct dev_cgroup *cur_devcgroup;
> const char *b;
> char *endp;
> - int retval = 0, count;
> + int count;
> struct dev_whitelist_item wh;
>
> if (!capable(CAP_SYS_ADMIN))
> @@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
> }
>
> handle:
> - retval = 0;
> switch (filetype) {
> case DEVCG_ALLOW:
> if (!parent_has_perm(devcgroup, &wh))
> --
> 1.5.4.rc3
>