2008-08-19 13:47:20

by Adrian Bunk

Subject: [2.6 patch] mm/hugetlb.c: make resv_map_{alloc,release}() static

This patch makes the needlessly global resv_map_{alloc,release}()
static.

Signed-off-by: Adrian Bunk <[email protected]>

---
99bcfd48d93a0c6286b6345f52d10a0a1a43f8c4
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 28a2980..c3bb4d6 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -262,7 +262,7 @@ struct resv_map {
struct list_head regions;
};

-struct resv_map *resv_map_alloc(void)
+static struct resv_map *resv_map_alloc(void)
{
struct resv_map *resv_map = kmalloc(sizeof(*resv_map), GFP_KERNEL);
if (!resv_map)
@@ -274,7 +274,7 @@ struct resv_map *resv_map_alloc(void)
return resv_map;
}

-void resv_map_release(struct kref *ref)
+static void resv_map_release(struct kref *ref)
{
struct resv_map *resv_map = container_of(ref, struct resv_map, refs);

2008-08-26 09:33:42

by Andy Whitcroft

Subject: Re: [2.6 patch] mm/hugetlb.c: make resv_map_{alloc,release}() static

On Tue, Aug 19, 2008 at 04:46:57PM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global resv_map_{alloc,release}()
> static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: Andy Whitcroft <[email protected]>

> 99bcfd48d93a0c6286b6345f52d10a0a1a43f8c4
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 28a2980..c3bb4d6 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -262,7 +262,7 @@ struct resv_map {
> struct list_head regions;
> };
>
> -struct resv_map *resv_map_alloc(void)
> +static struct resv_map *resv_map_alloc(void)
> {
> struct resv_map *resv_map = kmalloc(sizeof(*resv_map), GFP_KERNEL);
> if (!resv_map)
> @@ -274,7 +274,7 @@ struct resv_map *resv_map_alloc(void)
> return resv_map;
> }
>
> -void resv_map_release(struct kref *ref)
> +static void resv_map_release(struct kref *ref)
> {
> struct resv_map *resv_map = container_of(ref, struct resv_map, refs);

-apw