2008-10-05 10:17:40

by Michal Januszewski

Subject: [PATCH] x86: replace a magic number with a named constant in the VESA boot code

Replace a magic number with a named constant in the VESA boot code.

Signed-off-by: Michal Januszewski <[email protected]>
---
diff --git a/arch/x86/boot/video-vesa.c b/arch/x86/boot/video-vesa.c
index 401ad99..1e6fe02 100644
--- a/arch/x86/boot/video-vesa.c
+++ b/arch/x86/boot/video-vesa.c
@@ -224,7 +224,7 @@ static void vesa_store_pm_info(void)
static void vesa_store_mode_params_graphics(void)
{
/* Tell the kernel we're in VESA graphics mode */
- boot_params.screen_info.orig_video_isVGA = 0x23;
+ boot_params.screen_info.orig_video_isVGA = VIDEO_TYPE_VLFB;

/* Mode parameters */
boot_params.screen_info.vesa_attributes = vminfo.mode_attr;

2008-10-05 16:44:42

by Ingo Molnar

Subject: Re: [PATCH] x86: replace a magic number with a named constant in the VESA boot code

* Michal Januszewski <[email protected]> wrote:

> Replace a magic number with a named constant in the VESA boot code.
>
> Signed-off-by: Michal Januszewski <[email protected]>
> ---
> diff --git a/arch/x86/boot/video-vesa.c b/arch/x86/boot/video-vesa.c

applied to tip/x86/setup, thanks Michal!

Ingo