Subject: Re: [PATCH 2/3] ide-cd: small drive type print fix

On Monday 29 September 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <[email protected]>

applied (though I fail to see "an added value" of this change)

> ---
> drivers/ide/ide-cd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 9ffce7f..e41b94d 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -1784,7 +1784,7 @@ static int ide_cdrom_probe_capabilities(ide_drive_t *drive)
> if ((cdi->mask & CDC_DVD_R) == 0 || (cdi->mask & CDC_DVD_RAM) == 0)
> printk(KERN_CONT " DVD%s%s",
> (cdi->mask & CDC_DVD_R) ? "" : "-R",
> - (cdi->mask & CDC_DVD_RAM) ? "" : "-RAM");
> + (cdi->mask & CDC_DVD_RAM) ? "" : "/RAM");
>
> if ((cdi->mask & CDC_CD_R) == 0 || (cdi->mask & CDC_CD_RW) == 0)
> printk(KERN_CONT " CD%s%s",


2008-10-04 08:28:48

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH 2/3] ide-cd: small drive type print fix

On Fri, Oct 03, 2008 at 07:18:15PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Monday 29 September 2008, Borislav Petkov wrote:
> > Signed-off-by: Borislav Petkov <[email protected]>
>
> applied (though I fail to see "an added value" of this change)

It simply makes the format consistent with the lines below: CD-R/RW - which is
the more common way of enumerating supported media you find in different specs
than DVD-R-RAM, don't you think?

> > ---
> > drivers/ide/ide-cd.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> > index 9ffce7f..e41b94d 100644
> > --- a/drivers/ide/ide-cd.c
> > +++ b/drivers/ide/ide-cd.c
> > @@ -1784,7 +1784,7 @@ static int ide_cdrom_probe_capabilities(ide_drive_t *drive)
> > if ((cdi->mask & CDC_DVD_R) == 0 || (cdi->mask & CDC_DVD_RAM) == 0)
> > printk(KERN_CONT " DVD%s%s",
> > (cdi->mask & CDC_DVD_R) ? "" : "-R",
> > - (cdi->mask & CDC_DVD_RAM) ? "" : "-RAM");
> > + (cdi->mask & CDC_DVD_RAM) ? "" : "/RAM");
> >
> > if ((cdi->mask & CDC_CD_R) == 0 || (cdi->mask & CDC_CD_RW) == 0)
> > printk(KERN_CONT " CD%s%s",

--
Regards/Gruss,
Boris.

Subject: Re: [PATCH 2/3] ide-cd: small drive type print fix

On Saturday 04 October 2008, Borislav Petkov wrote:
> On Fri, Oct 03, 2008 at 07:18:15PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Monday 29 September 2008, Borislav Petkov wrote:
> > > Signed-off-by: Borislav Petkov <[email protected]>
> >
> > applied (though I fail to see "an added value" of this change)
>
> It simply makes the format consistent with the lines below: CD-R/RW - which is
> the more common way of enumerating supported media you find in different specs
> than DVD-R-RAM, don't you think?

Indeed, thanks for explaining it.