On Tue, 30 Sep 2008 16:57:39 -0700 Randy Dunlap wrote:
> On Tue, 30 Sep 2008 16:29:38 -0700 Yinghai Lu wrote:
>
> > change enable_mtrr_cleanup to mtrr-cleanup, disable_mtrr_cleanup to nomtrr-cleanup.
> >
> > Signed-off-by: Yinghai Lu <[email protected]>
> >
> > ---
> > Documentation/kernel-parameters.txt | 4 ++--
> > arch/x86/Kconfig | 2 +-
> > arch/x86/kernel/cpu/mtrr/main.c | 4 ++--
> > 3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > Index: linux-2.6/Documentation/kernel-parameters.txt
> > ===================================================================
> > --- linux-2.6.orig/Documentation/kernel-parameters.txt
> > +++ linux-2.6/Documentation/kernel-parameters.txt
> > @@ -614,8 +614,8 @@ and is between 256 and 4096 characters.
> > See drivers/char/README.epca and
> > Documentation/digiepca.txt.
> >
> > - disable_mtrr_cleanup [X86]
> > - enable_mtrr_cleanup [X86]
> > + nomtrr-cleanup [X86]
> > + mtrr-cleanup [X86]
> > The kernel tries to adjust MTRR layout from continuous
> > to discrete, to make X server driver able to add WB
> > entry later. This parameter enables/disables that.
>
> Looks like Documentation/kernel-parameters.txt needs a comment that says that
> entries are supposed to be listed in alphabetical order, not grouped by <subject>.
> Please don't add them like this.
BTW, this comment is alread in Documentation/kernel-parameters.txt, at the top of the file:
The following is a consolidated list of the kernel parameters as implemented
(mostly) by the __setup() macro and sorted into English Dictionary order
(defined as ignoring all punctuation and sorting digits before letters in a
case insensitive manner), and with descriptions where known.
> E.g., the "apic" entries are not grouped together and these mtrr entries should
> not be grouped together unless they all begin with "mtrr", which is an option here:
> they could be renamed to "mtrr-cleanup" and "mtrr-nocleanup".
> And "disable_mtrr_trim" could be renamed to "mtrr-notrim".
---
~Randy
On Wed, Oct 8, 2008 at 5:07 PM, Randy Dunlap <[email protected]> wrote:
> On Tue, 30 Sep 2008 16:57:39 -0700 Randy Dunlap wrote:
>
> BTW, this comment is alread in Documentation/kernel-parameters.txt, at the top of the file:
oh...
>
> The following is a consolidated list of the kernel parameters as implemented
> (mostly) by the __setup() macro and sorted into English Dictionary order
> (defined as ignoring all punctuation and sorting digits before letters in a
> case insensitive manner), and with descriptions where known.
>
>
how about
like to filter out disable, enable, no, etc...
diff --git a/Documentation/kernel-parameters.txt
b/Documentation/kernel-parameters.txt
index 4b9ee9b..782e2b0 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -620,35 +620,6 @@ and is between 256 and 4096 characters. It is
defined in the file
See drivers/char/README.epca and
Documentation/digiepca.txt.
- disable_mtrr_cleanup [X86]
- enable_mtrr_cleanup [X86]
- The kernel tries to adjust MTRR layout from continuous
- to discrete, to make X server driver able to add WB
- entry later. This parameter enables/disables that.
-
- mtrr_chunk_size=nn[KMG] [X86]
- used for mtrr cleanup. It is largest continous chunk
- that could hold holes aka. UC entries.
-
- mtrr_gran_size=nn[KMG] [X86]
- Used for mtrr cleanup. It is granularity of mtrr block.
- Default is 1.
- Large value could prevent small alignment from
- using up MTRRs.
-
- mtrr_spare_reg_nr=n [X86]
- Format: <integer>
- Range: 0,7 : spare reg number
- Default : 1
- Used for mtrr cleanup. It is spare mtrr entries number.
- Set to 2 or more if your graphical card needs more.
-
- disable_mtrr_trim [X86, Intel and AMD only]
- By default the kernel will trim any uncacheable
- memory out of your available memory pool based on
- MTRR settings. This parameter disables that behavior,
- possibly causing your machine to run very slowly.
-
dmasound= [HW,OSS] Sound subsystem buffers
dscc4.setup= [NET]
@@ -1310,6 +1281,35 @@ and is between 256 and 4096 characters. It is
defined in the file
[HW] Make the MicroTouch USB driver use raw coordinates
('y', default) or cooked coordinates ('n')
+ disable_mtrr_cleanup [X86]
+ enable_mtrr_cleanup [X86]
+ The kernel tries to adjust MTRR layout from continuous
+ to discrete, to make X server driver able to add WB
+ entry later. This parameter enables/disables that.
+
+ mtrr_chunk_size=nn[KMG] [X86]
+ used for mtrr cleanup. It is largest continous chunk
+ that could hold holes aka. UC entries.
+
+ mtrr_gran_size=nn[KMG] [X86]
+ Used for mtrr cleanup. It is granularity of mtrr block.
+ Default is 1.
+ Large value could prevent small alignment from
+ using up MTRRs.
+
+ mtrr_spare_reg_nr=n [X86]
+ Format: <integer>
+ Range: 0,7 : spare reg number
+ Default : 1
+ Used for mtrr cleanup. It is spare mtrr entries number.
+ Set to 2 or more if your graphical card needs more.
+
+ disable_mtrr_trim [X86, Intel and AMD only]
+ By default the kernel will trim any uncacheable
+ memory out of your available memory pool based on
+ MTRR settings. This parameter disables that behavior,
+ possibly causing your machine to run very slowly.
+
n2= [NET] SDL Inc. RISCom/N2 synchronous serial card
NCR_D700= [HW,SCSI]
On Wed, 8 Oct 2008 18:28:39 -0700 Yinghai Lu wrote:
> On Wed, Oct 8, 2008 at 5:07 PM, Randy Dunlap <[email protected]> wrote:
> > On Tue, 30 Sep 2008 16:57:39 -0700 Randy Dunlap wrote:
> >
> > BTW, this comment is alread in Documentation/kernel-parameters.txt, at the top of the file:
>
> oh...
>
> >
> > The following is a consolidated list of the kernel parameters as implemented
> > (mostly) by the __setup() macro and sorted into English Dictionary order
> > (defined as ignoring all punctuation and sorting digits before letters in a
> > case insensitive manner), and with descriptions where known.
> >
> >
> how about
>
> like to filter out disable, enable, no, etc...
I don't think that mtrr gets any special treatment here.
All "acpi" parameters are not grouped together (unless they begin with
"acpi"). All "apic" parameters are not grouped together.
All "*iommu*" parameters are not grouped together....
> diff --git a/Documentation/kernel-parameters.txt
> b/Documentation/kernel-parameters.txt
> index 4b9ee9b..782e2b0 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -620,35 +620,6 @@ and is between 256 and 4096 characters. It is
> defined in the file
> See drivers/char/README.epca and
> Documentation/digiepca.txt.
>
> - disable_mtrr_cleanup [X86]
> - enable_mtrr_cleanup [X86]
> - The kernel tries to adjust MTRR layout from continuous
> - to discrete, to make X server driver able to add WB
> - entry later. This parameter enables/disables that.
> -
> - mtrr_chunk_size=nn[KMG] [X86]
> - used for mtrr cleanup. It is largest continous chunk
> - that could hold holes aka. UC entries.
> -
> - mtrr_gran_size=nn[KMG] [X86]
> - Used for mtrr cleanup. It is granularity of mtrr block.
> - Default is 1.
> - Large value could prevent small alignment from
> - using up MTRRs.
> -
> - mtrr_spare_reg_nr=n [X86]
> - Format: <integer>
> - Range: 0,7 : spare reg number
> - Default : 1
> - Used for mtrr cleanup. It is spare mtrr entries number.
> - Set to 2 or more if your graphical card needs more.
> -
> - disable_mtrr_trim [X86, Intel and AMD only]
> - By default the kernel will trim any uncacheable
> - memory out of your available memory pool based on
> - MTRR settings. This parameter disables that behavior,
> - possibly causing your machine to run very slowly.
> -
> dmasound= [HW,OSS] Sound subsystem buffers
>
> dscc4.setup= [NET]
> @@ -1310,6 +1281,35 @@ and is between 256 and 4096 characters. It is
> defined in the file
> [HW] Make the MicroTouch USB driver use raw coordinates
> ('y', default) or cooked coordinates ('n')
>
> + disable_mtrr_cleanup [X86]
> + enable_mtrr_cleanup [X86]
> + The kernel tries to adjust MTRR layout from continuous
> + to discrete, to make X server driver able to add WB
> + entry later. This parameter enables/disables that.
> +
> + mtrr_chunk_size=nn[KMG] [X86]
> + used for mtrr cleanup. It is largest continous chunk
> + that could hold holes aka. UC entries.
> +
> + mtrr_gran_size=nn[KMG] [X86]
> + Used for mtrr cleanup. It is granularity of mtrr block.
> + Default is 1.
> + Large value could prevent small alignment from
> + using up MTRRs.
> +
> + mtrr_spare_reg_nr=n [X86]
> + Format: <integer>
> + Range: 0,7 : spare reg number
> + Default : 1
> + Used for mtrr cleanup. It is spare mtrr entries number.
> + Set to 2 or more if your graphical card needs more.
> +
> + disable_mtrr_trim [X86, Intel and AMD only]
> + By default the kernel will trim any uncacheable
> + memory out of your available memory pool based on
> + MTRR settings. This parameter disables that behavior,
> + possibly causing your machine to run very slowly.
> +
> n2= [NET] SDL Inc. RISCom/N2 synchronous serial card
>
> NCR_D700= [HW,SCSI]
>
---
~Randy
On Thu, Oct 9, 2008 at 10:20 AM, Randy Dunlap <[email protected]> wrote:
> On Wed, 8 Oct 2008 18:28:39 -0700 Yinghai Lu wrote:
>
>> On Wed, Oct 8, 2008 at 5:07 PM, Randy Dunlap <[email protected]> wrote:
>> > On Tue, 30 Sep 2008 16:57:39 -0700 Randy Dunlap wrote:
>> >
>> > BTW, this comment is alread in Documentation/kernel-parameters.txt, at the top of the file:
>>
>> oh...
>>
>> >
>> > The following is a consolidated list of the kernel parameters as implemented
>> > (mostly) by the __setup() macro and sorted into English Dictionary order
>> > (defined as ignoring all punctuation and sorting digits before letters in a
>> > case insensitive manner), and with descriptions where known.
>> >
>> >
>> how about
>>
>> like to filter out disable, enable, no, etc...
>
> I don't think that mtrr gets any special treatment here.
> All "acpi" parameters are not grouped together (unless they begin with
> "acpi"). All "apic" parameters are not grouped together.
> All "*iommu*" parameters are not grouped together....
could adjust acpi iommu to same layout
YH
Yinghai Lu wrote:
>>>
>>> like to filter out disable, enable, no, etc...
>> I don't think that mtrr gets any special treatment here.
>> All "acpi" parameters are not grouped together (unless they begin with
>> "acpi"). All "apic" parameters are not grouped together.
>> All "*iommu*" parameters are not grouped together....
>
> could adjust acpi iommu to same layout
>
I think the point is that it shouldn't be...
-hpa