2008-10-06 09:35:36

by David John

Subject: [PATCH] HPET: Remove spurious HPET busy warning message.

On x86 systems with CONFIG_HPET_TIMER enabled
and the HPET driver (drivers/char/hpet.c) compiled in,
an incorrect busy message is printed when the driver
initializes since the HPET has already been allocated
by the core timer code. Remove the warning message.

Signed-off-by: David John <[email protected]>
---
drivers/char/hpet.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index b3f5dbc..454c13b 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
hdp->hd_address = ioremap(addr.minimum, addr.address_length);

if (hpet_is_known(hdp)) {
- printk(KERN_DEBUG "%s: 0x%lx is busy\n",
- __func__, hdp->hd_phys_address);
iounmap(hdp->hd_address);
return AE_ALREADY_EXISTS;
}
@@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
HPET_RANGE_SIZE);

if (hpet_is_known(hdp)) {
- printk(KERN_DEBUG "%s: 0x%lx is busy\n",
- __func__, hdp->hd_phys_address);
iounmap(hdp->hd_address);
return AE_ALREADY_EXISTS;
}

2008-10-08 19:16:19

by Pallipadi, Venkatesh

Subject: Re: [PATCH] HPET: Remove spurious HPET busy warning message.

Yes. This printk is not adding much value and tend to get people confused
making them think that it is some sort of error. It will be good to get rid
of them.

Ingo: Can you pick this patch up into tip?

Thanks,
Venki

Acked-by: Venkatesh Pallipadi <[email protected]>

On Mon, Oct 06, 2008 at 01:52:20AM -0700, David John wrote:
> On x86 systems with CONFIG_HPET_TIMER enabled
> and the HPET driver (drivers/char/hpet.c) compiled in,
> an incorrect busy message is printed when the driver
> initializes since the HPET has already been allocated
> by the core timer code. Remove the warning message.
>
> Signed-off-by: David John <[email protected]>
> ---
> drivers/char/hpet.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index b3f5dbc..454c13b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> hdp->hd_address = ioremap(addr.minimum, addr.address_length);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }
> @@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> HPET_RANGE_SIZE);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }

2008-10-10 07:27:14

by Ingo Molnar

Subject: Re: [PATCH] HPET: Remove spurious HPET busy warning message.

* David John <[email protected]> wrote:

> On x86 systems with CONFIG_HPET_TIMER enabled, when
> the HPET driver (drivers/char/hpet.c) is loaded,
> an incorrect busy message is printed when the driver
> initializes since the HPET has already been allocated
> by the core timer code. Remove the warning message.
>
> Signed-off-by: David John <[email protected]>
> Acked-by: Venkatesh Pallipadi <[email protected]>
> ---
> drivers/char/hpet.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index b3f5dbc..454c13b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> hdp->hd_address = ioremap(addr.minimum, addr.address_length);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }
> @@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
> HPET_RANGE_SIZE);
>
> if (hpet_is_known(hdp)) {
> - printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> - __func__, hdp->hd_phys_address);
> iounmap(hdp->hd_address);
> return AE_ALREADY_EXISTS;
> }

applied to tip/timers/hpet, thanks John!

Ingo