2008-10-11 20:29:49

by Sitsofe Wheeler

Subject: [PATCH linux-tip] x86: Change OPTIMIZE_INLINING help to say enabling makes smaller kernels

The OPTIMIZE_INLINING help currently says "The gcc 4.x series have a
rewritten inlining algorithm and disabling this option will generate a
smaller kernel there."

This contradicts other parts of the help text and my own tests:
5463127 2008-10-11 19:51 vmlinux.no-opt
5456152 2008-10-11 19:56 vmlinux.opt

Reword text to say that enabling OPTIMIZE_INLINING will lead to smaller
kernels with gcc 4.x or later.

Signed-off-by: Sitsofe Wheeler <[email protected]>
---

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index 6a75bc2..bdddfbc 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -395,10 +395,10 @@ config OPTIMIZE_INLINING
developers have marked 'inline'. Doing so takes away freedom from gcc to
do what it thinks is best, which is desirable for the gcc 3.x series of
compilers. The gcc 4.x series have a rewritten inlining algorithm and
- disabling this option will generate a smaller kernel there. Hopefully
- this algorithm is so good that allowing gcc4 to make the decision can
- become the default in the future, until then this option is there to
- test gcc for this.
+ enabling this option will generate a smaller kernel there. Hopefully
+ this algorithm is so good that allowing gcc 4.x and above to make the
+ decision will become the default in the future. Until then this option
+ is there to test gcc for this.

If unsure, say N.

--
Sitsofe | http://sucs.org/~sits/

2008-10-22 16:04:39

by Ingo Molnar

Subject: Re: [PATCH linux-tip] x86: Change OPTIMIZE_INLINING help to say enabling makes smaller kernels

* Sitsofe Wheeler <[email protected]> wrote:

> The OPTIMIZE_INLINING help currently says "The gcc 4.x series have a
> rewritten inlining algorithm and disabling this option will generate a
> smaller kernel there."
>
> This contradicts other parts of the help text and my own tests:
> 5463127 2008-10-11 19:51 vmlinux.no-opt
> 5456152 2008-10-11 19:56 vmlinux.opt
>
> Reword text to say that enabling OPTIMIZE_INLINING will lead to smaller
> kernels with gcc 4.x or later.
>
> Signed-off-by: Sitsofe Wheeler <[email protected]>

applied, thanks Sitsofe!

Ingo