2008-10-13 22:57:26

by Simon Holm Thøgersen

Subject: [PATCH] serial: remove unused variable

This fixes the following compile warning:

drivers/serial/8250.c: In function 'serial8250_init':
drivers/serial/8250.c:2963: warning: unused variable 'i'

that was introduced by b70ac771 (serial: allow 8250 to be used on sparc)
that removed the last use of the variable.

Signed-off-by: Simon Holm Thøgersen <[email protected]>
---
drivers/serial/8250.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index d4104a3..625fc20 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -2960,7 +2960,7 @@ EXPORT_SYMBOL(serial8250_unregister_port);

static int __init serial8250_init(void)
{
- int ret, i;
+ int ret;

if (nr_uarts > UART_NR)
nr_uarts = UART_NR;
--
1.5.6.2.255.gbed62

2008-10-14 05:50:24

by Amos Jianjun Kong

Subject: Re: [PATCH] serial: remove unused variable

On Tue, Oct 14, 2008 at 12:58:31AM +0200, Simon Holm Th�gersen wrote:
>This fixes the following compile warning:
>
>drivers/serial/8250.c: In function 'serial8250_init':
>drivers/serial/8250.c:2963: warning: unused variable 'i'
>
>that was introduced by b70ac771 (serial: allow 8250 to be used on sparc)
>that removed the last use of the variable.
>
>Signed-off-by: Simon Holm Thøgersen <[email protected]>
>---
> drivers/serial/8250.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
>index d4104a3..625fc20 100644
>--- a/drivers/serial/8250.c
>+++ b/drivers/serial/8250.c
>@@ -2960,7 +2960,7 @@ EXPORT_SYMBOL(serial8250_unregister_port);
>
> static int __init serial8250_init(void)
> {
>- int ret, i;
>+ int ret;
>
> if (nr_uarts > UART_NR)
> nr_uarts = UART_NR;

I find those code in this function __init serial8250_init(void)

for (i = 0; i < NR_IRQS; i++)
spin_lock_init(&irq_lists[i].lock);

So you do not remove the 'i'.

--
Jianjun Kong | Happy Hacking
HomePage: http://kongove.cn
Gtalk: [email protected]

2008-10-14 07:08:25

by Simon Holm Thøgersen

Subject: Re: [PATCH] serial: remove unused variable

tir, 14 10 2008 kl. 13:50 +0800, skrev Jianjun Kong:
> On Tue, Oct 14, 2008 at 12:58:31AM +0200, Simon Holm Th�gersen wrote:
> >This fixes the following compile warning:
> >
> >drivers/serial/8250.c: In function 'serial8250_init':
> >drivers/serial/8250.c:2963: warning: unused variable 'i'
> >
> >that was introduced by b70ac771 (serial: allow 8250 to be used on sparc)
> >that removed the last use of the variable.
> >
> >Signed-off-by: Simon Holm Thøgersen <[email protected]>
> >---
> > drivers/serial/8250.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> >index d4104a3..625fc20 100644
> >--- a/drivers/serial/8250.c
> >+++ b/drivers/serial/8250.c
> >@@ -2960,7 +2960,7 @@ EXPORT_SYMBOL(serial8250_unregister_port);
> >
> > static int __init serial8250_init(void)
> > {
> >- int ret, i;
> >+ int ret;
> >
> > if (nr_uarts > UART_NR)
> > nr_uarts = UART_NR;
>
> I find those code in this function __init serial8250_init(void)
>
> for (i = 0; i < NR_IRQS; i++)
> spin_lock_init(&irq_lists[i].lock);
>
> So you do not remove the 'i'.
>
Look at the referenced commit b70ac771 (serial: allow 8250 to be used on
sparc). It is quite recent (Mon Oct 13 10:36:31 2008 +0100), but if you
pull Linus' latest tree it is there.


Simon