2008-10-14 13:30:51

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH] Fix numlock led on Dell keyboard (413c:2105)

This keyboard needs to re-sync numlock after probing.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>

diff --git a/drivers/hid/hid-dell.c b/drivers/hid/hid-dell.c
index 98ee40e..1a0d0df 100644
--- a/drivers/hid/hid-dell.c
+++ b/drivers/hid/hid-dell.c
@@ -47,6 +47,7 @@ err_free:

static const struct hid_device_id dell_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_DELL, USB_DEVICE_ID_DELL_W7658) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_DELL, USB_DEVICE_ID_DELL_SK8115) },
{ }
};
MODULE_DEVICE_TABLE(hid, dell_devices);
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index fa4e4fd..b74c505 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -132,6 +132,7 @@

#define USB_VENDOR_ID_DELL 0x413c
#define USB_DEVICE_ID_DELL_W7658 0x2005
+#define USB_DEVICE_ID_DELL_SK8115 0x2105

#define USB_VENDOR_ID_DELORME 0x1163
#define USB_DEVICE_ID_DELORME_EARTHMATE 0x0100


2008-10-14 13:49:27

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH] Fix numlock led on Dell keyboard (413c:2105)

Mauro Carvalho Chehab napsal(a):
> This keyboard needs to re-sync numlock after probing.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> diff --git a/drivers/hid/hid-dell.c b/drivers/hid/hid-dell.c
> index 98ee40e..1a0d0df 100644
> --- a/drivers/hid/hid-dell.c
> +++ b/drivers/hid/hid-dell.c
> @@ -47,6 +47,7 @@ err_free:
>
> static const struct hid_device_id dell_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_DELL, USB_DEVICE_ID_DELL_W7658) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_DELL, USB_DEVICE_ID_DELL_SK8115) },

Add the line also to hid_blacklist in hid-core.c.

Thanks.

2008-10-14 22:03:25

by FD Cami

[permalink] [raw]
Subject: Re: [PATCH] Fix numlock led on Dell keyboard (413c:2105)


Hi Mauro,

On Tue, 14 Oct 2008 10:28:21 -0200
Mauro Carvalho Chehab <[email protected]> wrote:

> This keyboard needs to re-sync numlock after probing.

Do you mean, when you plug one, the numlock LED is on but numlock
may be off ?

Cheers

Francois

2008-10-14 22:11:46

by FD Cami

[permalink] [raw]
Subject: Re: [PATCH] Fix numlock led on Dell keyboard (413c:2105)

On Wed, 15 Oct 2008 00:03:14 +0200
FD Cami <[email protected]> wrote:

> On Tue, 14 Oct 2008 10:28:21 -0200
> Mauro Carvalho Chehab <[email protected]> wrote:
>
> > This keyboard needs to re-sync numlock after probing.
>
> Do you mean, when you plug one, the numlock LED is on but numlock
> may be off ?

Please ignore that one, I found your post from last week explaining
the issue.

Francois