2008-10-16 21:02:14

by Randy Dunlap

Subject: Re: mmotm 2008-10-16-00-52 uploaded (cgroup + mm)

On Thu, 16 Oct 2008, [email protected] wrote:

> The mm-of-the-moment snapshot 2008-10-16-00-52 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> It contains the following patches against 2.6.27:


build-r9168.out:(.text+0x261e6): undefined reference to `lookup_page_cgroup'
build-r9168.out:memcontrol.c:(.text+0x2629f): undefined reference to `lookup_page_cgroup'
build-r9168.out:memcontrol.c:(.text+0x2671a): undefined reference to `lookup_page_cgroup'
build-r9168.out:(.text+0x268f9): undefined reference to `lookup_page_cgroup'
build-r9168.out:memcontrol.c:(.text+0x26e52): undefined reference to `page_cgroup_init'
build-r9168.out:(.text+0x26f44): undefined reference to `lookup_page_cgroup'
build-r9168.out:(.init.text+0xe42): undefined reference to `pgdat_page_cgroup_init'


.config is at http://oss.oracle.com/~rdunlap/kerneltest/configs/config-r9168

--
~Randy

2008-10-17 00:31:19

by Kamezawa Hiroyuki

Subject: Re: mmotm 2008-10-16-00-52 uploaded (cgroup + mm)

On Thu, 16 Oct 2008 14:01:48 -0700 (PDT)
"Randy.Dunlap" <[email protected]> wrote:

> On Thu, 16 Oct 2008, [email protected] wrote:
>
> > The mm-of-the-moment snapshot 2008-10-16-00-52 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> >
> > It contains the following patches against 2.6.27:
>
>
> build-r9168.out:(.text+0x261e6): undefined reference to `lookup_page_cgroup'
> build-r9168.out:memcontrol.c:(.text+0x2629f): undefined reference to `lookup_page_cgroup'
> build-r9168.out:memcontrol.c:(.text+0x2671a): undefined reference to `lookup_page_cgroup'
> build-r9168.out:(.text+0x268f9): undefined reference to `lookup_page_cgroup'
> build-r9168.out:memcontrol.c:(.text+0x26e52): undefined reference to `page_cgroup_init'
> build-r9168.out:(.text+0x26f44): undefined reference to `lookup_page_cgroup'
> build-r9168.out:(.init.text+0xe42): undefined reference to `pgdat_page_cgroup_init'
>
>
> .config is at http://oss.oracle.com/~rdunlap/kerneltest/configs/config-r9168
>
Ouch...

Hmm....it seems

memcg-allocate-all-page_cgroup-at-boot.patch doesn't includes changes to Makefile...

Thank you for report. I'll send a fix soon.

Regards,
-Kame

2008-10-17 01:51:01

by Kamezawa Hiroyuki

Subject: [mmotm][PATCH] memcg-allocate-all-page_cgroup-at-boot-fix.patch

On Fri, 17 Oct 2008 09:30:46 +0900
KAMEZAWA Hiroyuki <[email protected]> wrote:
> Hmm....it seems
>
> memcg-allocate-all-page_cgroup-at-boot.patch doesn't includes changes to Makefile...
>
> Thank you for report. I'll send a fix soon.
>
This is a fix. for this.

Confirmed vmlinux can be compiled with the config.
(but need to turn off CONFIG_HID_SUPPORT..and found small troube in /samples
directory's Makefile.

-Kame
==

compile fix to memcg-allocate-all-page_cgroup-at-boot.patch


Signed-off-by: KAMEZAWA Hiroyuki <[email protected]>

mm/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.27/mm/Makefile
===================================================================
--- linux-2.6.27.orig/mm/Makefile
+++ linux-2.6.27/mm/Makefile
@@ -33,5 +33,5 @@ obj-$(CONFIG_FS_XIP) += filemap_xip.o
obj-$(CONFIG_MIGRATION) += migrate.o
obj-$(CONFIG_SMP) += allocpercpu.o
obj-$(CONFIG_QUICKLIST) += quicklist.o
-obj-$(CONFIG_CGROUP_MEM_RES_CTLR) += memcontrol.o
+obj-$(CONFIG_CGROUP_MEM_RES_CTLR) += memcontrol.o page_cgroup.o
obj-$(CONFIG_CGROUP_MEMRLIMIT_CTLR) += memrlimitcgroup.o