2008-10-17 13:20:51

by Amos Kong

Subject: [PATCH] include/linux/mca-legacy.h: Fix the warning

Fix the warning of annotation.

CC drivers/mca/mca-legacy.o
In file included from drivers/mca/mca-legacy.c:31:
include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy -
please move your driver to the new sysfs api"
In file included from drivers/mca/mca-legacy.c:31:
include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy -
please move your driver to the new sysfs api"

Signed-off-by: Jianjun Kong <[email protected]>
---
include/linux/mca-legacy.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/mca-legacy.h b/include/linux/mca-legacy.h
index 7a3aea8..e349f2b 100644
--- a/include/linux/mca-legacy.h
+++ b/include/linux/mca-legacy.h
@@ -9,7 +9,7 @@

#include <linux/mca.h>

-#warning "MCA legacy - please move your driver to the new sysfs api"
+/* warning "MCA legacy - please move your driver to the new sysfs api" */

/* MCA_NOTFOUND is an error condition. The other two indicate
* motherboard POS registers contain the adapter. They might be
--
1.5.2.5



--
Jianjun Kong | Happy Hacking
HomePage: http://kongove.cn
Gtalk: [email protected]

2008-10-17 13:30:30

by Adrian Bunk

Subject: Re: [PATCH] include/linux/mca-legacy.h: Fix the warning

On Fri, Oct 17, 2008 at 09:20:44PM +0800, Jianjun Kong wrote:
> Fix the warning of annotation.
>
> CC drivers/mca/mca-legacy.o
> In file included from drivers/mca/mca-legacy.c:31:
> include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy -
> please move your driver to the new sysfs api"
> In file included from drivers/mca/mca-legacy.c:31:
> include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy -
> please move your driver to the new sysfs api"
>
> Signed-off-by: Jianjun Kong <[email protected]>
> ---
> include/linux/mca-legacy.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/mca-legacy.h b/include/linux/mca-legacy.h
> index 7a3aea8..e349f2b 100644
> --- a/include/linux/mca-legacy.h
> +++ b/include/linux/mca-legacy.h
> @@ -9,7 +9,7 @@
>
> #include <linux/mca.h>
>
> -#warning "MCA legacy - please move your driver to the new sysfs api"
> +/* warning "MCA legacy - please move your driver to the new sysfs api" */
>...

NAK

If you want to get rid of the warning fix the drivers still using the
obsolete API.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed