2008-10-17 20:57:59

by Dotan Barak

Subject: [PATCH] workqueues: fix some linux coding style typos

workqueues: fix some linux coding style typos:

* spaces were replaced with tabs
* "foo* bar" was replaced with "foo *bar"

Signed-off-by: Dotan Barak <[email protected]>

---

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 714afad..f9de8b5 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -300,7 +300,7 @@ static void run_workqueue(struct cpu_workqueue_struct *cwq)
printk(KERN_ERR "BUG: workqueue leaked lock or atomic: "
"%s/0x%08x/%d\n",
current->comm, preempt_count(),
- task_pid_nr(current));
+ task_pid_nr(current));
printk(KERN_ERR " last function: ");
print_symbol("%s\n", (unsigned long)f);
debug_show_held_locks(current);
@@ -551,7 +551,7 @@ static void wait_on_work(struct work_struct *work)
}

static int __cancel_work_timer(struct work_struct *work,
- struct timer_list* timer)
+ struct timer_list *timer)
{
int ret;

@@ -908,7 +908,7 @@ void destroy_workqueue(struct workqueue_struct *wq)

for_each_cpu_mask_nr(cpu, *cpu_map)
cleanup_workqueue_thread(per_cpu_ptr(wq->cpu_wq, cpu));
- cpu_maps_update_done();
+ cpu_maps_update_done();

free_percpu(wq->cpu_wq);
kfree(wq);

2008-10-18 01:51:19

by Amos Kong

Subject: [PATCH] kernel/workqueue.c mm/sparse.c: fix some linux coding style typos

On Sat, Oct 18, 2008 at 05:16:39AM +0200, Dotan Barak wrote:
>workqueues: fix some linux coding style typos:
>
>* spaces were replaced with tabs
>* "foo* bar" was replaced with "foo *bar"
>
>Signed-off-by: Dotan Barak <[email protected]>
>
>---
>
>diff --git a/kernel/workqueue.c b/kernel/workqueue.c
>index 714afad..f9de8b5 100644
>--- a/kernel/workqueue.c
>+++ b/kernel/workqueue.c
>@@ -300,7 +300,7 @@ static void run_workqueue(struct cpu_workqueue_struct *cwq)

The same problem is in mm/sparse.c .

* spaces were replaced with tabs
* "foo* bar" was replaced with "foo *bar"

Signed-off-by: Dotan Barak <[email protected]>
Signed-off-by: Jianjun Kong <[email protected]>
---
kernel/workqueue.c | 6 +++---
mm/sparse.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 714afad..f9de8b5 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -300,7 +300,7 @@ static void run_workqueue(struct cpu_workqueue_struct *cwq)
printk(KERN_ERR "BUG: workqueue leaked lock or atomic: "
"%s/0x%08x/%d\n",
current->comm, preempt_count(),
- task_pid_nr(current));
+ task_pid_nr(current));
printk(KERN_ERR " last function: ");
print_symbol("%s\n", (unsigned long)f);
debug_show_held_locks(current);
@@ -551,7 +551,7 @@ static void wait_on_work(struct work_struct *work)
}

static int __cancel_work_timer(struct work_struct *work,
- struct timer_list* timer)
+ struct timer_list *timer)
{
int ret;

@@ -908,7 +908,7 @@ void destroy_workqueue(struct workqueue_struct *wq)

for_each_cpu_mask_nr(cpu, *cpu_map)
cleanup_workqueue_thread(per_cpu_ptr(wq->cpu_wq, cpu));
- cpu_maps_update_done();
+ cpu_maps_update_done();

free_percpu(wq->cpu_wq);
kfree(wq);
diff --git a/mm/sparse.c b/mm/sparse.c
index 39db301..47cb5c3 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -114,7 +114,7 @@ static inline int sparse_index_init(unsigned long section_nr, int nid)
* to also work for the flat array case because
* NR_SECTION_ROOTS==NR_MEM_SECTIONS.
*/
-int __section_nr(struct mem_section* ms)
+int __section_nr(struct mem_section *ms)
{
unsigned long root_nr;
struct mem_section* root;
--
1.5.2.5

--
Jianjun Kong | Happy Hacking
HomePage: http://kongove.cn
Gtalk: [email protected]