2008-10-18 03:52:24

by Huang Weiyi

Subject: staging: SLICOSS: remove duplicated #include's

Removed duplicated #include's in drivers/staging/slicoss/slicoss.c.
linux/delay.h
linux/etherdevice.h
linux/init.h
linux/netdevice.h
linux/pci.h
linux/skbuff.h
linux/slab.h
linux/string.h

Signed-off-by: Huang Weiyi <[email protected]>

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss
index b61ac4b..059f7e3 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -96,17 +96,9 @@
#include <linux/moduleparam.h>

#include <linux/types.h>
-#include <linux/slab.h>
-#include <linux/delay.h>
-#include <linux/init.h>
-#include <linux/pci.h>
#include <linux/dma-mapping.h>
-#include <linux/netdevice.h>
-#include <linux/etherdevice.h>
#include <linux/mii.h>
#include <linux/if_vlan.h>
-#include <linux/skbuff.h>
-#include <linux/string.h>
#include <asm/unaligned.h>

#include <linux/ethtool.h>

2008-10-20 21:37:39

by Greg KH

Subject: Re: staging: SLICOSS: remove duplicated #include's

On Sat, Oct 18, 2008 at 11:52:11AM +0800, Huang Weiyi wrote:
> Removed duplicated #include's in drivers/staging/slicoss/slicoss.c.
> linux/delay.h
> linux/etherdevice.h
> linux/init.h
> linux/netdevice.h
> linux/pci.h
> linux/skbuff.h
> linux/slab.h
> linux/string.h

Do you have some script that you run to catch all of these?

thanks,

greg k-h