2008-10-20 19:31:17

by Dotan Barak

Subject: checkpatch.pl print the line twice when trailing statements in the same line

Hi.

I executed checkpatch.pl version 0.24 on a file and i noticed that when
a tailing statement is being declared at the same line with "while, checkpatch
prints the erroneous line twice.

Here is an example of the output:

ERROR: trailing statements should be on next line
#651: FILE: idbm.c:651:
+ while (*nl && isspace(c = *nl)) nl++;
+ while (*nl && isspace(c = *nl)) nl++;

Is this is the expected behavior?

Thanks
Dotan

2008-10-31 08:24:35

by Andy Whitcroft

Subject: Re: checkpatch.pl print the line twice when trailing statements in the same line

On Mon, Oct 20, 2008 at 08:51:38PM +0200, Dotan Barak wrote:
> Hi.
>
> I executed checkpatch.pl version 0.24 on a file and i noticed that when
> a tailing statement is being declared at the same line with "while, checkpatch
> prints the erroneous line twice.
>
> Here is an example of the output:
>
> ERROR: trailing statements should be on next line
> #651: FILE: idbm.c:651:
> + while (*nl && isspace(c = *nl)) nl++;
> + while (*nl && isspace(c = *nl)) nl++;
>
> Is this is the expected behavior?

No that would definintaly not be expected. Will add it to my TODO list.

Thanks for the report.

-apw

2008-11-12 13:55:17

by Andy Whitcroft

Subject: Re: checkpatch.pl print the line twice when trailing statements in the same line

On Fri, Oct 31, 2008 at 08:24:14AM +0000, Andy Whitcroft wrote:
> On Mon, Oct 20, 2008 at 08:51:38PM +0200, Dotan Barak wrote:
> > Hi.
> >
> > I executed checkpatch.pl version 0.24 on a file and i noticed that when
> > a tailing statement is being declared at the same line with "while, checkpatch
> > prints the erroneous line twice.
> >
> > Here is an example of the output:
> >
> > ERROR: trailing statements should be on next line
> > #651: FILE: idbm.c:651:
> > + while (*nl && isspace(c = *nl)) nl++;
> > + while (*nl && isspace(c = *nl)) nl++;
> >
> > Is this is the expected behavior?
>
> No that would definintaly not be expected. Will add it to my TODO list.

Ok, this is now fixed up and should be in my next batch of updates.

-apw

2008-11-12 15:38:29

by Dotan Barak

Subject: Re: checkpatch.pl print the line twice when trailing statements in the same line

Thanks.

I noticed another issue:

for the code line:
return (int)0;

I get the following error message:
ERROR: return is not a function, parentheses are not required.

Thanks
Dotan

On Wed, Nov 12, 2008 at 3:54 PM, Andy Whitcroft <[email protected]> wrote:
> On Fri, Oct 31, 2008 at 08:24:14AM +0000, Andy Whitcroft wrote:
>> On Mon, Oct 20, 2008 at 08:51:38PM +0200, Dotan Barak wrote:
>> > Hi.
>> >
>> > I executed checkpatch.pl version 0.24 on a file and i noticed that when
>> > a tailing statement is being declared at the same line with "while, checkpatch
>> > prints the erroneous line twice.
>> >
>> > Here is an example of the output:
>> >
>> > ERROR: trailing statements should be on next line
>> > #651: FILE: idbm.c:651:
>> > + while (*nl && isspace(c = *nl)) nl++;
>> > + while (*nl && isspace(c = *nl)) nl++;
>> >
>> > Is this is the expected behavior?
>>
>> No that would definintaly not be expected. Will add it to my TODO list.
>
> Ok, this is now fixed up and should be in my next batch of updates.
>
> -apw
>