2008-10-21 14:08:48

by Jens Osterkamp

Subject: [PATCH] edac/cell: enable polling mode

From: Benjamin Herrenschmidt <[email protected]>

The edac driver on cell turned out to be not enabled because of a missing op_state.
This patch introduces it. Verified to work on top of Bens next branch.

Signed-off-by: Arnd Bergmann <[email protected]>
Signed-off-by: Jens Osterkamp <[email protected]>

---

Ben, can you please confirm this is the patch you wanted to send upstream ?

Index: linux-2.6/drivers/edac/cell_edac.c
===================================================================
--- linux-2.6.orig/drivers/edac/cell_edac.c
+++ linux-2.6/drivers/edac/cell_edac.c
@@ -9,6 +9,7 @@
*/
#undef DEBUG

+#include <linux/edac.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/platform_device.h>
@@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
if (regs == NULL)
return -ENODEV;

+ edac_op_state = EDAC_OPSTATE_POLL;
+
/* Get channel population */
reg = in_be64(&regs->mic_mnt_cfg);
dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);
---

Gru?,

Jens

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Gesch?ftsf?hrung: Erich Baier
Sitz der Gesellschaft: B?blingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

2008-10-21 20:59:41

by Benjamin Herrenschmidt

Subject: Re: [PATCH] edac/cell: enable polling mode

On Tue, 2008-10-21 at 16:07 +0200, Jens Osterkamp wrote:
> From: Benjamin Herrenschmidt <[email protected]>
>
> The edac driver on cell turned out to be not enabled because of a missing op_state.
> This patch introduces it. Verified to work on top of Bens next branch.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Jens Osterkamp <[email protected]>

Acked-by: Benjamin Herrenschmidt <[email protected]>
> ---
>
> Ben, can you please confirm this is the patch you wanted to send upstream ?

Yes.

> Index: linux-2.6/drivers/edac/cell_edac.c
> ===================================================================
> --- linux-2.6.orig/drivers/edac/cell_edac.c
> +++ linux-2.6/drivers/edac/cell_edac.c
> @@ -9,6 +9,7 @@
> */
> #undef DEBUG
>
> +#include <linux/edac.h>
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> @@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
> if (regs == NULL)
> return -ENODEV;
>
> + edac_op_state = EDAC_OPSTATE_POLL;
> +
> /* Get channel population */
> reg = in_be64(&regs->mic_mnt_cfg);
> dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);
> ---
>
> Gruß,
>
> Jens
>
> IBM Deutschland Entwicklung GmbH
> Vorsitzender des Aufsichtsrats: Martin Jetter
> Geschäftsführung: Erich Baier
> Sitz der Gesellschaft: Böblingen
> Registergericht: Amtsgericht Stuttgart, HRB 243294