2008-10-21 14:16:59

by Amos Kong

Subject: [PATCH] fork.c: fix a problem of code style

fix a problem of code style

Signed-off-by: Jianjun Kong <[email protected]>
---
kernel/fork.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index 30de644..b6e5a94 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -187,7 +187,7 @@ void __init fork_init(unsigned long mempages)
/*
* we need to allow at least 20 threads to boot a system
*/
- if(max_threads < 20)
+ if (max_threads < 20)
max_threads = 20;

init_task.signal->rlim[RLIMIT_NPROC].rlim_cur = max_threads/2;
--
1.5.2.5

--
Jianjun Kong | Happy Hacking
HomePage: http://kongove.cn
Gtalk: [email protected]

2008-10-21 16:01:49

by Christoph Lameter

Subject: Re: [PATCH] fork.c: fix a problem of code style

For what its worth

Reviewed-by: Christoph Lameter <[email protected]>

2008-10-21 16:32:37

by David Newall

Subject: Re: [PATCH] fork.c: fix a problem of code style

Jianjun Kong wrote:
> - if(max_threads < 20)
> + if (max_threads < 20)

I thought we didn't bother with trivial style changes like this.

2008-10-29 00:29:22

by Andrew Morton

Subject: Re: [PATCH] fork.c: fix a problem of code style

On Wed, 22 Oct 2008 03:02:21 +1030
David Newall <[email protected]> wrote:

> Jianjun Kong wrote:
> > - if(max_threads < 20)
> > + if (max_threads < 20)
>
> I thought we didn't bother with trivial style changes like this.

Yes, it's too small:

akpm:/usr/src/25> perl scripts/checkpatch.pl --file kernel/fork.c | grep total
total: 34 errors, 13 warnings, 1689 lines checked

We could merge thousands and thousand of one-line patches like this and
it's all very inefficient.

I'd consider larger patches which cleaned up whole subdirectories.
They're not much fun to maintain but we don't regret these things after
we've done them.