2008-10-31 21:04:36

by Chuck Ebbert

[permalink] [raw]
Subject: [patch] x86: Kill bogus MTRR warning when running under vmware

x86: Kill bogus MTRR warning when running under vmware

The warning is suppressed when running under KVM, but VMware
guests also have empty MTRRs.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=468845

Signed-off-by: Chuck Ebbert <[email protected]>

Index: linux-2.6.27.noarch/arch/x86/kernel/cpu/mtrr/main.c
===================================================================
--- linux-2.6.27.noarch.orig/arch/x86/kernel/cpu/mtrr/main.c
+++ linux-2.6.27.noarch/arch/x86/kernel/cpu/mtrr/main.c
@@ -1495,11 +1495,8 @@ int __init mtrr_trim_uncached_memory(uns
}

/* kvm/qemu doesn't have mtrr set right, don't trim them all */
- if (!highest_pfn) {
- WARN(!kvm_para_available(), KERN_WARNING
- "WARNING: strange, CPU MTRRs all blank?\n");
+ if (!highest_pfn)
return 0;
- }

/* check entries number */
memset(num, 0, sizeof(num));


2008-11-03 08:49:11

by Ingo Molnar

[permalink] [raw]
Subject: Re: [patch] x86: Kill bogus MTRR warning when running under vmware


* Chuck Ebbert <[email protected]> wrote:

> x86: Kill bogus MTRR warning when running under vmware
>
> The warning is suppressed when running under KVM, but VMware
> guests also have empty MTRRs.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=468845

we are working on proper "are we within vmware" detection support.
Patches already exist and it is useful to know it for other reasons as
wel.

Ingo