2008-11-10 05:28:27

by Harvey Harrison

Subject: [PATCH] x86: x86_32 has its own irq_regs definition

Impact: prevent second percpu define of unused irq_regs

Arches that have their own irq_regs definition are expected to
define ARCH_HAS_OWN_IRQ_REGS or else a generic (unused) set
will also be defined in lib/irq_regs.c

Sparse noticed the unused generic one had no prototype:
lib/irq_regs.c:15:1: warning: symbol 'per_cpu____irq_regs' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <[email protected]>
---
arch/x86/include/asm/irq_regs_32.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/include/asm/irq_regs_32.h b/arch/x86/include/asm/irq_regs_32.h
index af2f02d..86afd74 100644
--- a/arch/x86/include/asm/irq_regs_32.h
+++ b/arch/x86/include/asm/irq_regs_32.h
@@ -9,6 +9,8 @@

#include <asm/percpu.h>

+#define ARCH_HAS_OWN_IRQ_REGS
+
DECLARE_PER_CPU(struct pt_regs *, irq_regs);

static inline struct pt_regs *get_irq_regs(void)
--
1.6.0.3.866.gc189b

2008-11-10 07:42:24

by Ingo Molnar

Subject: Re: [PATCH] x86: x86_32 has its own irq_regs definition

* Harvey Harrison <[email protected]> wrote:

> Impact: prevent second percpu define of unused irq_regs
>
> Arches that have their own irq_regs definition are expected to
> define ARCH_HAS_OWN_IRQ_REGS or else a generic (unused) set
> will also be defined in lib/irq_regs.c
>
> Sparse noticed the unused generic one had no prototype:
> lib/irq_regs.c:15:1: warning: symbol 'per_cpu____irq_regs' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <[email protected]>
> ---
> arch/x86/include/asm/irq_regs_32.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)

applied to tip/x86/cleanups, thanks Harvey!

Ingo